incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Lalancette <clala...@redhat.com>
Subject Re: [PATCH] Restores delete firewall rule semantics:
Date Thu, 30 Jun 2011 20:44:52 GMT
On 06/27/11 - 05:22:18PM, marios@redhat.com wrote:
> From: marios <marios@redhat.com>
> 
> DELETE /api/firewalls/:firewall/:rule_id
> 
> Signed-off-by: marios <marios@redhat.com>
> ---
>  server/lib/deltacloud/drivers/ec2/ec2_driver.rb |    2 +-
>  server/server.rb                                |   31 ++++++++++------------
>  server/views/firewalls/show.html.haml           |    3 +-
>  3 files changed, 16 insertions(+), 20 deletions(-)

Hey Marios,
     Sorry for the long delay here.  This patch is most of what I would like
to see, though there is one thing missing.  In the XML for the firewall rule,
I think we should export the URL for the rule as well, similar to how blobs
have a full URL.  Something like this (untested) patch?

-- 
Chris Lalancette

Mime
View raw message