incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Francesco Vollero <fvoll...@redhat.com>
Subject Re: [PATCH core] Fix long username for RHEVM driver
Date Mon, 06 Jun 2011 13:11:39 GMT
On Mon, Jun 06, 2011 at 08:59:09AM -0400, Chris Lalancette wrote:
> On 06/06/11 - 02:44:15PM, Francesco Vollero wrote:
> > This patch is to fix a problem with Base64.b64encode for credentials in RHEVM driver,
due to a wrong way in pack to add \n every 60 chars i had to use this hack.

[snip]

> ACK to the code, it looks fine.  I would suggest adding a better comment to the
> code, though, so the next person reading the code isn't confused.  Something
> like:
> 
> # in ruby 1.8, the Base64.encode64 method automatically adds \n after every
> # 60 characters.  Strip that out here.  Ruby 1.9 has Base64.strict_encode64()
> # which does not have this problem.
>

Thanks for the suggestion Chris. I wrote it in hurry, but next time i will try to be more
clear.

Cheers,
Francesco Vollero

> -- 
> Chris Lalancette

Mime
View raw message