Mailing-List: contact deltacloud-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltacloud-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of mfojtik@redhat.com designates
 209.132.183.28 as permitted sender)
Subject: Re: Improved error/exception reporting (rev 2)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Michal Fojtik <mfojtik@redhat.com>
In-Reply-To: <4DB9ACCD.1070606@redhat.com>
Date: Tue, 3 May 2011 16:34:03 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <9FB064CF-7FBB-408C-A8AA-AA2D1046FA08@redhat.com>
References: <1303902480-4906-1-git-send-email-mfojtik@redhat.com>
 <4DB9ACCD.1070606@redhat.com>
To: deltacloud-dev@incubator.apache.org


On Apr 28, 2011, at 8:07 PM, marios@redhat.com wrote:

> ACK (minor typo needs fixing before commit):
>=20
> * clean application (minor whitespace [non] issue)
>=20
> * Rakefile lines 124/125/126 - typo - you forgot to specify the :mock =
namespace (e.g. Rake::Task["mock:fixtures:clean"].invoke) so gives an =
error
>=20
> * The rake mock:setup/clean/reset stuff is very nice and long overdue =
- can we automate this during install? (e.g. add it in 'rake package' =
for example)
>=20
> * Code 502 'Backend error' - previously you used to get a full stack =
trace in the 'details' field - i don't know if its better without it but =
this is a matter of opinion. You could argue that its better without it =
since it doesn't give you any new information (e.g. you know the problem =
happened in 'buckets' method since thats what you requested - but imo =
more information is always better for debugging.
>=20

Thanks!

I fixed Rakefile and pushed the patchset to SVN. Re 520: I probably =
forgot to add this information here, thanks!.

  -- Michal


>=20
> marios
>=20
> On 27/04/11 14:07, mfojtik@redhat.com wrote:
>> Hi,
>>=20
>> this patchset combine my previous error handling DSL patch and fix =
all tests/issues
>> so far. (all our test suites are green).
>>=20
>> Also I recently realized, that we don't have mechanism to 'reset' =
mock data in mock dir.
>> So I updated Rakefile and nwo there are couple tasks for dealing with =
mock data (setup, clean, reset)
>>=20
>> All error pages were updated to be more verbose for users (well HTML =
pages are helpfull just for developers,
>> which is another reason I increased verbosity). So no you can see =
backtrace, HTTP status code explanation,
>> request and response headers and of course status code.
>>=20
>> Since we already discussed fir revision and so far it was 'acked' =
verbaly ;-) I just resending rebased patch
>> with this additions. For those who look on my previous patch, first =
patch in this set is not interesting.
>>=20
>>   -- Michal
>>=20
>=20

------------------------------------------------------
Michal Fojtik, mfojtik@redhat.com
Deltacloud API: http://deltacloud.org