incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Lalancette <clala...@redhat.com>
Subject Re: [PATCH] Fix keyname listing in EC2.
Date Fri, 27 May 2011 13:57:24 GMT
On 05/27/11 - 03:55:30PM, marios@redhat.com wrote:
> On 27/05/11 15:41, Chris Lalancette wrote:
> >On 05/27/11 - 01:00:06PM, marios@redhat.com wrote:
> >>ACK, thanks and nice catch - pushing this with a couple additional
> >>changes to show.html.haml and index.xml.haml which weren't
> >>displaying the key/passwords (if present for given driver).
> >>
> >
> >Thanks.
> >
> >More generally, should we make a common function that both
> >views/instances/index.xml.haml and views/instances/show.xml.haml share, so that
> >they will always be in-sync?[1]
> >
> 
> thats a good idea - i often find that there is much repetition in
> these two (as you say, across the board) - but not always so this
> needs to be done carefully - I'll add a task to 'the list' [1].

Cool, thanks.

> 
> Slightly unrelated but not warranting it's own email - sorry for not
> preserving your 'signed-off-by' in by git push regarding keys
> earlier. I've been playing with git trying to work out how... so far
> I've always used 'cat some_patch.txt | git apply' to my branch, and
> then committed. I only just realised that 'git am some.eml' actually
> applies the patch preserving the commit line. Its only taken me
> like, a year +some, but there you go :)  -  Will do that in future,

No worries.  I'm glad you've learned about git-am :).

-- 
Chris Lalancette

Mime
View raw message