incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/2] Attaching EBS snapshot to instance upon creation time
Date Mon, 09 May 2011 23:39:47 GMT
On Mon, 2011-05-09 at 13:34 +0200, mfojtik@redhat.com wrote:
> diff --git a/server/lib/deltacloud/base_driver/features.rb b/server/lib/deltacloud/base_driver/features.rb
> index f978640..33ab61d 100644
> --- a/server/lib/deltacloud/base_driver/features.rb
> +++ b/server/lib/deltacloud/base_driver/features.rb
> @@ -232,6 +232,14 @@ module Deltacloud
>        end
>      end
>  
> +    declare_feature :instances, :attach_ebs_snapshot do
> +      description "Number of instances to be launch with at once"

Cut & paste error ? ;)

> +      operation :create do
> +        param :ebs_snapshot_id,  :string,  :optional
> +        param :device_name,  :string,  :optional
> +      end
> +    end

Can we drop the 'ebs' from the parameter (and feature) name ? I would
hope that other clouds would provide this functionality in a very
similar way ;)

Additionally, this only exposes a small part of the EC2
BlockDeviceMapping feature; we don't need to expose everything right
now, but how will we evolve the API to support things like mapping
multiple volumes ?

David



Mime
View raw message