incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: EC2 driver rewrite (rev 2) + Tobi patches
Date Fri, 26 Nov 2010 16:03:34 GMT
While we are waiting for Toby's fix to be pulled into aws by the appoxy 
guys, I used rvm to test the new gem (thx Michal), specifically we 
wanted to see if regions are supported by the new gem (so we can switch 
to using that).

It looks like the 'EU' and 'US' regions are supported for creating 
buckets. However, things start blowing up when you try to specify the 
'asia pacific' or the 'us-west-1' endpoints (see 
http://docs.amazonwebservices.com/AmazonS3/2006-03-01/dev/index.html?LocationSelection.html

and 
http://docs.amazonwebservices.com/AmazonS3/2006-03-01/dev/index.html?RequestEndpoints.html).

I've spent a couple hours poking at the aws gem but can't see what's 
amiss. It doesn't even make sense since aws is based on right_aws which 
*did* support all regions without problem. Unless anyone beats me to it, 
I'll pick this up Monday.

With risk of this last point being overlooked - I propose that we split 
this patch-bomb (nuke?) into its constituent parts - for sure the new 
ec2 driver warrants its own stand-alone patch.



marios

On 25/11/10 12:25, Michal Fojtik wrote:
> On 19/11/10 13:39 +0200, marios@redhat.com wrote:
>> nack
>>
>> Theres too much going on in this patch series - I specifically looked
>> at whether the new gem and/or new driver breaks buckets (and wanted to
>> check region support but couldn't get that far).
>>
>> I cannot get a bucket listing - looks like its a problem with the aws
>> gem (tried through irb and am getting the same result). Michal you
>> already said that this works for you but it seems Toby had the
>> same problem as me so not sure what's going on.
>>
>> Trace looks like:
>>
>> <snip>
>>
>> irb(main):013:0> s3_client.buckets
>> #<ArgumentError: wrong number of arguments (2 for 1)>
>
> To better clarify this, this bug exists for Ruby version <= 1.8.6.
> So Fedora 13 is affected with this bug (and RHEL5). Anyway, Tobi's patch
> should fix this problem, lets wait for appoxy guys.
>
> Btw. meanwhile I tested S3 region support under 1.8.7 and seems like it
> works:
>
> <snip>
> irb(main):011:0> s3_client.bucket('mfojtik-awesome-bucket', true,
> 'public-read', :location => :eu)
> Closing HTTPS connection to s3.amazonaws.com:443
> Opening new HTTPS connection to mfojtik-awesome-bucket.s3.amazonaws.com:443
> => #<Aws::S3::Bucket:0xb6f81928 @creation_date=nil,
> @name="mfojtik-awesome-bucket", @s3=#<Aws::S3:0xb6fa5ad0 </snip>
>
> -- Michal
>
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:49:in
>> `const_get'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:49:in
>> `constantize'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:48:in
>> `each'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:48:in
>> `constantize'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3_interface.rb:158:in
>> `generate_rest_request'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3_interface.rb:191:in
>> `list_all_my_buckets'/usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3.rb:83:in
>> `buckets'(irb):13:in
>> `irb_binding'/usr/lib/ruby/1.8/irb/workspace.rb:52:in
>> `irb_binding'/usr/lib/ruby/1.8/irb/workspace.rb:52.join('
>> ')}
>> Request was: -none-
>> Response was: -none-
>> ArgumentError: wrong number of arguments (2 for 1)
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:49:in
>> `const_get'
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:49:in
>> `constantize'
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:48:in
>> `each'
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/awsbase/support.rb:48:in
>> `constantize'
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3_interface.rb:158:in
>> `generate_rest_request'
>> from
>> /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3_interface.rb:191:in
>> `list_all_my_buckets'
>> from /usr/lib/ruby/gems/1.8/gems/aws-2.3.26/lib/s3/right_s3.rb:83:in
>> `buckets'
>> from (irb):13
>>
>> </snip>
>>
>>
>> marios
>>
>>
>> On 15/11/10 14:46, mfojtik@redhat.com wrote:
>>> Hi,
>>>
>>> So in this patchbomb you can find all previous EC2 patches and Tobi
>>> patches
>>> applied on top. This patches should be applied on top of master.
>>>
>>> Updates:
>>>
>>> - Fixed/Updated cucumber features
>>> - Added 'state' to Key
>>> - Added Cucumber features for storage_volumes
>>> - Refreshed Mock data
>>>
>>> -- Michal
>>>
>>
>


Mime
View raw message