incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "marios@redhat.com" <mandr...@redhat.com>
Subject Re: ['PATCH'] Tidy up /server/lib/sinatra/respond_to.rb - 'stock' sinatra code was stripping off extension in requests (myblob.txt) and trying to guess content type based on that. This caused problems with blob names. First check for '?format=___' in request, or use http_accept header, or set to default content.
Date Fri, 24 Sep 2010 10:57:59 GMT

>
> Actually, I need to NACK this patch because lot of our specs are failing
> with this code. See attached output of 'rake test':
> Btw. after quick look on failed tests I think we will need update our
> tests to omit usage of '.format' and switch to '?format' instead.

ok mate thanks, yes forgot that we already used the 'auto-negotiation' 
stuff already for other collections - added to list for fixing,

marios


>
> Also please run:
>
> cd core/tests
> rake cucumber
> API_DRIVER="ec2" rake cucumber
>
> before this patch will be pushed. There are also some failures.
>
> -- Michal
>
>>
>


Mime
View raw message