Mailing-List: contact deltacloud-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: deltacloud-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of lutter@redhat.com designates
 209.132.183.28 as permitted sender)
Subject: Re: [PATCH] azure blob storage driver - very early prototype with
 basic functions
From: David Lutterkort <lutter@redhat.com>
To: deltacloud-dev@incubator.apache.org
In-Reply-To: <1282672321-6993-2-git-send-email-mandreou@redhat.com>
References: <1282672321-6993-1-git-send-email-mandreou@redhat.com>
	 <1282672321-6993-2-git-send-email-mandreou@redhat.com>
Content-Type: text/plain; charset="ISO-8859-15"
Organization: Red Hat Inc
Date: Thu, 26 Aug 2010 17:03:12 -0700
Message-ID: <1282867392.21129.380.camel@avon.watzmann.net>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Tue, 2010-08-24 at 18:52 +0100, mandreou@redhat.com wrote:
> diff --git a/server/lib/deltacloud/drivers/azure/azure_driver.rb b/server/lib/deltacloud/drivers/azure/azure_driver.rb
> new file mode 100644
> index 0000000..780e278
> --- /dev/null
> +++ b/server/lib/deltacloud/drivers/azure/azure_driver.rb
> @@ -0,0 +1,105 @@
>
> +#Windows Azure (WAZ) gem at http://github.com/johnnyhalife/waz-storage
> +require 'waz-blobs'
> +require 'deltacloud/base_driver'
> +module Deltacloud
> +  module Drivers
> +    module Azure
> +
> +class AzureDriver < Deltacloud::BaseDriver
> +
> +  def supported_collections
> +    DEFAULT_COLLECTIONS.reject! { |c| [:hardware_profiles, :images, :instances, :instance_states,
> +                                      :realms, :storage_volumes, :storage_snapshots  ].include?(c) }
> +    DEFAULT_COLLECTIONS + [:containers]
> +  end

Could just do 'def supported_collections; [:containers] end' here ;)

> +  def blobs(credentials, opts)
> +    blob_list = []
> +    unless opts['container'] then
> +      raise Deltacloud::Validation::Failure.new(Deltacloud::Validation::Param.new(["container"]), "Error - need container name to retrieve the blob list. You said container->#{opts['container']}.")
> +    end

Shouldn't this be handled by the declaration of containers in
server.rb ? In particular, since :container is part of the URL, this
method would never be called if it's not there.

Other than that, looks great.

David