Return-Path: Delivered-To: apmail-incubator-deltacloud-dev-archive@minotaur.apache.org Received: (qmail 76875 invoked from network); 28 Jul 2010 22:22:17 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Jul 2010 22:22:17 -0000 Received: (qmail 43917 invoked by uid 500); 28 Jul 2010 22:22:17 -0000 Delivered-To: apmail-incubator-deltacloud-dev-archive@incubator.apache.org Received: (qmail 43897 invoked by uid 500); 28 Jul 2010 22:22:16 -0000 Mailing-List: contact deltacloud-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: deltacloud-dev@incubator.apache.org Delivered-To: mailing list deltacloud-dev@incubator.apache.org Received: (qmail 43889 invoked by uid 99); 28 Jul 2010 22:22:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 22:22:16 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=10.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of lutter@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 22:22:09 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o6SMLkK6015524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 28 Jul 2010 18:21:46 -0400 Received: from [10.3.113.13] ([10.3.113.13]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o6SMLkbV013711; Wed, 28 Jul 2010 18:21:46 -0400 Subject: Re: [PATCH core 1/2] Added owner_id feature for EC2 From: David Lutterkort To: deltacloud-dev@incubator.apache.org Cc: Michal Fojtik In-Reply-To: <1280320779-31659-2-git-send-email-mfojtik@redhat.com> References: <1280320779-31659-1-git-send-email-mfojtik@redhat.com> <1280320779-31659-2-git-send-email-mfojtik@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Organization: Red Hat Inc Date: Wed, 28 Jul 2010 15:21:46 -0700 Message-ID: <1280355706.4000.33.camel@avon.watzmann.net> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 2010-07-28 at 14:39 +0200, mfojtik@redhat.com wrote: > --- > server/lib/deltacloud/base_driver/features.rb | 7 +++++++ > server/server.rb | 1 - > 2 files changed, 7 insertions(+), 1 deletions(-) ACK; one small thing: > diff --git a/server/lib/deltacloud/base_driver/features.rb b/server/lib/deltacloud/base_driver/features.rb > index 8ad354a..55dfdbe 100644 > --- a/server/lib/deltacloud/base_driver/features.rb > +++ b/server/lib/deltacloud/base_driver/features.rb > @@ -120,6 +120,13 @@ module Deltacloud > # > # Declaration of optional features > # > + declare_feature :images, :owner_id do > + description "Filter images using owner id" > + operation :index do > + param :owner_id, :string, :optional, nil, "Amazon EC2 user ID" This still mentions EC2. It should say something like 'ID of the owner' or some such. David