incubator-deltacloud-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Lutterkort <lut...@redhat.com>
Subject Re: [PATCH core 1/2] Added owner_id feature for EC2
Date Wed, 28 Jul 2010 22:21:46 GMT
On Wed, 2010-07-28 at 14:39 +0200, mfojtik@redhat.com wrote:
> ---
>  server/lib/deltacloud/base_driver/features.rb |    7 +++++++
>  server/server.rb                              |    1 -
>  2 files changed, 7 insertions(+), 1 deletions(-)

ACK; one small thing:

> diff --git a/server/lib/deltacloud/base_driver/features.rb b/server/lib/deltacloud/base_driver/features.rb
> index 8ad354a..55dfdbe 100644
> --- a/server/lib/deltacloud/base_driver/features.rb
> +++ b/server/lib/deltacloud/base_driver/features.rb
> @@ -120,6 +120,13 @@ module Deltacloud
>      #
>      # Declaration of optional features
>      #
> +    declare_feature :images,  :owner_id do
> +      description "Filter images using owner id"
> +      operation :index do
> +        param :owner_id,  :string,  :optional,  nil,  "Amazon EC2 user ID"

This still mentions EC2. It should say something like 'ID of the owner'
or some such.

David



Mime
View raw message