incubator-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cross...@apache.org
Subject svn commit: r835769 - /incubator/public/trunk/clutch.py
Date Fri, 13 Nov 2009 07:48:35 GMT
Author: crossley
Date: Fri Nov 13 07:48:35 2009
New Revision: 835769

URL: http://svn.apache.org/viewvc?rev=835769&view=rev
Log:
Rushed bug fix. Ensure url to mail list. The "hasMailListCommits" variable is
naughtily being used for two purposes. When non-existent mail list, then the
report generation code is trying to link to a local non-url.

Modified:
    incubator/public/trunk/clutch.py

Modified: incubator/public/trunk/clutch.py
URL: http://svn.apache.org/viewvc/incubator/public/trunk/clutch.py?rev=835769&r1=835768&r2=835769&view=diff
==============================================================================
--- incubator/public/trunk/clutch.py (original)
+++ incubator/public/trunk/clutch.py Fri Nov 13 07:48:35 2009
@@ -35,6 +35,7 @@
 
 
 # FIXME: mentorsList needs better splitting.
+# FIXME: Mail list detection. See svn comments with 2009-11-13 rush bug fix.
 # FIXME: Occasional trailing slash issue in Clutch cache.
 # FIXME: Some projects use different names in different contexts, and cannot
 #        be automatically handled, e.g. Lucene.Net, log4php (some of their stats
@@ -1042,13 +1043,23 @@
     fileXml.write('          <td class="care">False</td>\n')
   output[k]['urlTracker'] = projects[k]['urlTracker']
 
-  if projects[k]['hasMailListDev']:
+  matchUrl = re.search(urlHttpRE, projects[k]['hasMailListDev'])
+  if matchUrl:
+    hasUrl = True
+  else:
+    hasUrl = False
+  if hasUrl:
     fileXml.write('          <td class="cool1"><a href="%s">True</a></td>\n'
% projects[k]['hasMailListDev'])
   else:
     fileXml.write('          <td class="care">False</td>\n')
   output[k]['hasMailListDev'] = projects[k]['hasMailListDev']
 
-  if projects[k]['hasMailListCommits']:
+  matchUrl = re.search(urlHttpRE, projects[k]['hasMailListCommits'])
+  if matchUrl:
+    hasUrl = True
+  else:
+    hasUrl = False
+  if hasUrl:
     fileXml.write('          <td class="cool1"><a href="%s">True</a></td>\n'
% projects[k]['hasMailListCommits'])
   else:
     fileXml.write('          <td class="care">False</td>\n')



---------------------------------------------------------------------
To unsubscribe, e-mail: cvs-unsubscribe@incubator.apache.org
For additional commands, e-mail: cvs-help@incubator.apache.org


Mime
View raw message