incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Beech (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-142) Context not being passed to FilterFn instances wrapped in boolean AndFn,OrFn,NotFn
Date Mon, 14 Jan 2013 16:50:16 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552875#comment-13552875
] 

Dave Beech commented on CRUNCH-142:
-----------------------------------

Yeah, I think that'd be OK. The behaviour might still be inconsistent depending on how you've
decided to chain the filters, but for me it's still much better than not calling the child
function at all. 
                
> Context not being passed to FilterFn instances wrapped in boolean AndFn,OrFn,NotFn
> ----------------------------------------------------------------------------------
>
>                 Key: CRUNCH-142
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-142
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.4.0
>            Reporter: Dave Beech
>            Assignee: Gabriel Reid
>             Fix For: 0.5.0
>
>         Attachments: CRUNCH-142_1.patch, CRUNCH-142_2.patch, CRUNCH-142.patch
>
>
> The boolean filter classes AndFn, OrFn and NotFn delegate calls to FilterFn instances
internally, but setContext is not called on these first. 
> As a result, methods which need the context such as getCounter() fail with NullPointerException.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message