Return-Path: X-Original-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C1D34D8E2 for ; Wed, 5 Dec 2012 21:14:00 +0000 (UTC) Received: (qmail 86314 invoked by uid 500); 5 Dec 2012 21:14:00 -0000 Delivered-To: apmail-incubator-crunch-dev-archive@incubator.apache.org Received: (qmail 86284 invoked by uid 500); 5 Dec 2012 21:14:00 -0000 Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: crunch-dev@incubator.apache.org Delivered-To: mailing list crunch-dev@incubator.apache.org Received: (qmail 86229 invoked by uid 99); 5 Dec 2012 21:14:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Dec 2012 21:14:00 +0000 Date: Wed, 5 Dec 2012 21:14:00 +0000 (UTC) From: "Gabriel Reid (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: <375578330.64928.1354742040266.JavaMail.jiratomcat@arcas> In-Reply-To: <1905156613.60640.1354659058609.JavaMail.jiratomcat@arcas> Subject: [jira] [Commented] (CRUNCH-124) Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510770#comment-13510770 ] Gabriel Reid commented on CRUNCH-124: ------------------------------------- [~jwills] I think the way it is now will be fine. You're probably right that the most common use-case is using SpecificRecord, and it's not that big of a bother to provide the PType for the other use cases when necessary. In my Avro experience, I've never really relied on generic records, although in the past I did use the reflection-based Avro serialization (together with Lombok-annotated classes) quite a bit to do quick prototyping, which basically gives you the same as working with SpecificRecords without the hassle of creating a schema or generating classes. I think that this was mostly motivated by laziness, and I don't think it was that common of a use case. > Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles > ----------------------------------------------------------------------------------------- > > Key: CRUNCH-124 > URL: https://issues.apache.org/jira/browse/CRUNCH-124 > Project: Crunch > Issue Type: Improvement > Components: IO > Reporter: Josh Wills > Attachments: CRUNCH-124.patch > > > Aside from org.apache.crunch.*, the o.a.c.io.(From|To|At) methods are among the most user-facing classes we have. We should javadoc them thoroughly and add more convenience methods that make them easier to get started with for new Crunch users. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira