incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-124) Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles
Date Fri, 07 Dec 2012 16:25:21 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526504#comment-13526504
] 

Matthias Friedrich commented on CRUNCH-124:
-------------------------------------------

Looks good to me. I don't like large interfaces, or long, complex implementation classes,
but From, To, and At are neither. I can live with with big collections of static factory methods,
the complexity is encapsulated elsewhere and it's convenient for users. There are a few warnings
I'd clean up though, FileInputFormat could use its generic parameters.
                
> Javadoc the From, To, and At static methods and add convenience methods for sequenceFiles
> -----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-124
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-124
>             Project: Crunch
>          Issue Type: Improvement
>          Components: IO
>            Reporter: Josh Wills
>         Attachments: CRUNCH-124.patch
>
>
> Aside from org.apache.crunch.*, the o.a.c.io.(From|To|At) methods are among the most
user-facing classes we have. We should javadoc them thoroughly and add more convenience methods
that make them easier to get started with for new Crunch users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message