incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-122) Reduce visibility of implementation classes
Date Sun, 02 Dec 2012 15:17:58 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias Friedrich updated CRUNCH-122:
--------------------------------------

    Attachment: CRUNCH-122-v2.patch

Found more stuff we can hide. Limits the amount of javadoc we have to write.
                
> Reduce visibility of implementation classes
> -------------------------------------------
>
>                 Key: CRUNCH-122
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-122
>             Project: Crunch
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Matthias Friedrich
>            Assignee: Matthias Friedrich
>            Priority: Trivial
>         Attachments: CRUNCH-122-Make-impl-classes-package-private.patch, CRUNCH-122-v2.patch
>
>
> There are a few implementation classes that are used only from within their home package.
Thus, they should be package-private instead of public, which also hides them from javadoc.
Most of these classes aren't from our set of "published" packages anyway but it's good style
to hide them if we can. We can also make inner DoFns private if there is a static factory
method for them.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message