incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-113) Move log4j hacking out of MRPipeline.enableDebug
Date Wed, 14 Nov 2012 17:30:13 GMT


Matthias Friedrich commented on CRUNCH-113:

Sure. One question though: In which scenario do you expect to see a difference? When running
via LocalJobRunner from a JUnit test case? Or when running as a Java application from within
Eclipse? I've never noticed a difference from this logger magic, so I'd like to reject the
null hypothesis ;-)
> Move log4j hacking out of MRPipeline.enableDebug
> ------------------------------------------------
>                 Key: CRUNCH-113
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>    Affects Versions: 0.3.0, 0.4.0
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>             Fix For: 0.5.0
>         Attachments: CRUNCH-113.patch
> MRPipeline.enableDebug currently does some shenanigans with the log4j LogManager object
to override external log4j configuration. After a lengthy thread, we came to the consensus
that this was a bad idea, and so we're going to move the shenanigans out of MRPipeline and
into a static method in crunch-test where they won't be able to do as much harm.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message