incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Friedrich (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-93) Crunch core source should not contain packages like o.a.c.test
Date Wed, 17 Oct 2012 16:52:03 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias Friedrich updated CRUNCH-93:
-------------------------------------

    Attachment: CRUNCH-97-mafr.patch

+1. Just had a look at it, this is really good work, I like how it simplifies DoFn. I'm willing
to pay the price of pulling in another dependency since it's limited to MemCollection and
javassist is distributed under the Apache License (among others). After all, we can get rid
of it in the distant future when we don't have to support Hadoop 1 anymore.

I've made a few cosmetic changes and reformatted your commit message (there was a newline
missing which leads to git putting everything into a single line). Hope you don't mind.
                
> Crunch core source should not contain packages like o.a.c.test 
> ---------------------------------------------------------------
>
>                 Key: CRUNCH-93
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-93
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Rahul Sharma
>            Priority: Minor
>         Attachments: 0001-CRUNCH-93-moving-test-support-classes.patch, CRUNCH-97-mafr.patch
>
>
> Crunch core has the following things a package named o.a.c.test and TestCounters class.The
source should not contain test package and classes named with Test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message