Return-Path: 
 <crunch-dev-return-885-apmail-incubator-crunch-dev-archive=incubator.apache.org@incubator.apache.org>
X-Original-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org
Delivered-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id AAF00DADE
	for <apmail-incubator-crunch-dev-archive@minotaur.apache.org>;
 Thu, 20 Sep 2012 05:45:08 +0000 (UTC)
Received: (qmail 54565 invoked by uid 500); 20 Sep 2012 05:45:08 -0000
Delivered-To: apmail-incubator-crunch-dev-archive@incubator.apache.org
Received: (qmail 54507 invoked by uid 500); 20 Sep 2012 05:45:08 -0000
Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:crunch-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:crunch-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:crunch-dev@incubator.apache.org>
List-Id: <crunch-dev.incubator.apache.org>
Reply-To: crunch-dev@incubator.apache.org
Delivered-To: mailing list crunch-dev@incubator.apache.org
Received: (qmail 54204 invoked by uid 99); 20 Sep 2012 05:45:07 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Sep 2012 05:45:07 +0000
Date: Thu, 20 Sep 2012 16:45:07 +1100 (NCT)
From: "Vinod Kumar Vavilapalli (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <300765320.101019.1348119907978.JavaMail.jiratomcat@arcas>
In-Reply-To: <788369825.101008.1348119427737.JavaMail.jiratomcat@arcas>
Subject: [jira] [Updated] (CRUNCH-70) Simplify Pipeline API
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CRUNCH-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kumar Vavilapalli updated CRUNCH-70:
------------------------------------------

    Attachment: CRUNCH-70-20120919.txt

Here's a patch to do this.

I added a util called Pipelines following the convention.

One question though (left as a TODO in the patch): In writeTextFile() run as part of a MR pipeline, we do the following:
{code}
+      collection =
+          collection.parallelDo("asText", IdentityFn.<T> getInstance(),
+            WritableTypeFamily.getInstance().as(collection.getPType()));
{code}

Why do we do it? And do we really need MRPipeline to force the PTypeFamily to be Writables?
                
> Simplify Pipeline API
> ---------------------
>
>                 Key: CRUNCH-70
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-70
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Vinod Kumar Vavilapalli
>         Attachments: CRUNCH-70-20120919.txt
>
>
> Today Pipeline interface has the following APIs which really belong to a utils class:
>  - readTextFile
>  - writeTextFile
>  - enableDebug
> The implementation of these APIs is the same in both the Pipeline-types present today and are most likely going to be the same if ever we have one more impl.
> I propose we move these to a util/lib to make the core interface cleaner.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira