Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: crunch-dev@incubator.apache.org
Date: Fri, 21 Sep 2012 03:33:08 +1100 (NCT)
From: "Matthias Friedrich (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <1639094385.103430.1348158788470.JavaMail.jiratomcat@arcas>
In-Reply-To: <1537533761.97986.1348073107501.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CRUNCH-68) Crunch examples don't accept generic
 tool arguments
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CRUNCH-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459719#comment-13459719 ] 

Matthias Friedrich commented on CRUNCH-68:
------------------------------------------

Hi Brock, thanks a lot for helping us out here!

Building multiple example JARs seems excessive, let's just remove the mainClass from the manifest and then fix things according to 2) and 3).
                
> Crunch examples don't accept generic tool arguments
> ---------------------------------------------------
>
>                 Key: CRUNCH-68
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-68
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.3.0
>            Reporter: Roman Shaposhnik
>            Assignee: Matthias Friedrich
>             Fix For: 0.4.0
>
>         Attachments: CRUNCH-68-Fix-command-line-parser-for-examples.patch
>
>
> Currently all crunch examples have the following code:
> {noformat}
>     if (args.length != 3) {
>       System.err.println();
>       System.err.println("Usage: " + this.getClass().getName() + " [generic options] input output");
>       System.err.println();
>       GenericOptionsParser.printGenericCommandUsage(System.err);
>       return 1;
>     }
> {noformat}
> this is incorrect since run() gets to see all arguments even generic ones and thus you can't predict the value of 
> args.length.
> This is also, unfortunately a major blocker, for using Crunch with Hadoop 2 because of a MAPREDUCE-4068. 
> Essentially at this point a combination of MAPREDUCE-4068 and inability to pass -libjars makes Crunch example DOA for Hadoop 2 clusters.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira