incubator-crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-74) Reset method of Agregator should have a Configuration param
Date Fri, 28 Sep 2012 04:41:08 GMT


Gabriel Reid commented on CRUNCH-74:

I'm definitely still in support of the initialize method (even if I am getting confused between
an interface and abstract class :-)). I think that staying consistent with everything else
in Crunch, i.e. making the initialize method a one-time up-front method, is the way to go.

I can't see any situation where passing the Configuration in to reset() would make anything
else easier or possible, so I would prefer to stick with consistency. 
> Reset method of Agregator should have a Configuration param
> -----------------------------------------------------------
>                 Key: CRUNCH-74
>                 URL:
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Rahul Sharma
>            Priority: Minor
>         Attachments: 0001-Adding-configuration-to-reset-method-in-Aggregator.patch
> The rest method of aggregator is called for every key that is being received at the reducer.
The purpose of the reset method is to re-initialize any values if required. The initialization
may require some job params or user params from configuration object. There should be a parameter
to reset method which will have the configuration that is being used.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

View raw message