Return-Path: X-Original-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-crunch-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5C07ED3CA for ; Wed, 1 Aug 2012 15:02:03 +0000 (UTC) Received: (qmail 84762 invoked by uid 500); 1 Aug 2012 15:02:03 -0000 Delivered-To: apmail-incubator-crunch-dev-archive@incubator.apache.org Received: (qmail 84734 invoked by uid 500); 1 Aug 2012 15:02:03 -0000 Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: crunch-dev@incubator.apache.org Delivered-To: mailing list crunch-dev@incubator.apache.org Received: (qmail 84704 invoked by uid 99); 1 Aug 2012 15:02:03 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2012 15:02:03 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 267B71404B4 for ; Wed, 1 Aug 2012 15:02:03 +0000 (UTC) Date: Wed, 1 Aug 2012 15:02:03 +0000 (UTC) From: "Gauthier Ambard (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: <838869193.1097.1343833323161.JavaMail.jiratomcat@issues-vm> In-Reply-To: <607933850.3.1343813704239.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Updated] (CRUNCH-29) Add string concatenation in CombineFn MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gauthier Ambard updated CRUNCH-29: ---------------------------------- Attachment: 0001-CRUNCH-29-Patch-adding-string-concatenation.patch Yep, you are totally right. I hadn't dig deep enough in CombineFn to understand how to pass parameters... My bad. I have also included the SkipNulls method from Joiner (which was a great idea, thanks). Thanks for the tips ! > Add string concatenation in CombineFn > ------------------------------------- > > Key: CRUNCH-29 > URL: https://issues.apache.org/jira/browse/CRUNCH-29 > Project: Crunch > Issue Type: Improvement > Reporter: Gauthier Ambard > Priority: Minor > Labels: newbie > Attachments: 0001-CRUNCH-29-Patch-adding-string-concatenation.patch, 0001-CRUNCH-29-Patch-adding-string-concatenation.patch > > > Add two methods for string concatenation in CombineFn: one with a space acting as a separator between the string, and one without. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira