Mailing-List: contact crunch-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: crunch-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of christian.tzolov@gmail.com
 designates 209.85.160.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <86AEC9345436442F937C7B7D5681F39D@gmail.com>
References: <3fd46440-f94e-494c-a5c5-1f640d545f96@s6g2000pbi.googlegroups.com>
	<CAH29n6NP3kXLt6zoq7H9_ux-Jky54etd+4c3ombhv_PfQd8GWA@mail.gmail.com>
	<86AEC9345436442F937C7B7D5681F39D@gmail.com>
Date: Mon, 18 Jun 2012 08:42:47 +0200
Message-ID: 
 <CAGNdOEX=o1bR9=0Crhxqc8=_AsiKRhG-qsqUM_R-ScQduBpKeg@mail.gmail.com>
Subject: Re: Checkstyle & Reviews
From: Christian Tzolov <christian.tzolov@gmail.com>
To: Gabriel Reid <gabriel.reid@gmail.com>
Cc: Josh Wills <jwills@cloudera.com>, Robert Chu <robert@wibidata.com>,
	Crunch Dev <crunch-dev@cloudera.org>, crunch-dev@incubator.apache.org
Content-Type: multipart/alternative; boundary=047d7b162fd75923f504c2b979be

--047d7b162fd75923f504c2b979be
Content-Type: text/plain; charset=ISO-8859-1

+1 for shared eclipse code style configuration

IMO using code quality tools as maven plugins is inefficient and hard to
maintain. More consistent and complete solution would be use Hudson or
Jenkins. Not sure though if apache provides such CI tools?


On Sat, Jun 16, 2012 at 10:27 AM, Gabriel Reid <gabriel.reid@gmail.com>wrote:

> +1 for a style guide and/or formatting rules and coding rules.
>
> For code style, something that I've seen work well (at least if everyone
> is using Eclipse) is to just have a shared code style definition that you
> can import into Eclipse, and then set Eclipse to apply that style whenever
> you save a file. This works great if everyone uses the same style
> definition, and breaks down rapidly if they don't.
>
> I don't have any experience using the maven-findbugs-plugin, but I do find
> the Checkstyle useful, as long as the settings are sane (which is not
> always the case).
>
> On Saturday 16 June 2012 at 00:17, Josh Wills wrote:
>
> > I'm in favor of a style guide; consistent layout makes it easier for
> > my brain to devour code. That said, I'm not up-to-date on best
> > practices here in the real world; my only experience with automated
> > code review tools was at teh goog.
> >
> > Re: code reviews, let's start that discussion up in another thread.
> >
> > J
> >
> > On Fri, Jun 15, 2012 at 3:13 PM, Robert Chu <robert@wibidata.com(mailto:
> robert@wibidata.com)> wrote:
> > > Hey Everybody,
> > >
> > > I'd like to start a discussion about using automated code review tools
> > > to improve the crunch development process. I'd I'm personally a big
> > > fan of using tools that can help improve code quality. These tools
> > > often include things like the maven-checkstyle-plugin and the maven-
> > > findbugs-plugin. I am currently unaware of any comparable scala
> > > automated tools. If people have opinions on whether or not we should
> > > use tools like this or which tools we should be using specifically
> > > please let us know.
> > >
> > > Also, another related question: Should we have some sort of a code
> > > review process?
> > >
> > > Robert Chu
> >
> >
> >
> > --
> > Director of Data Science
> > Cloudera
> > Twitter: @josh_wills
>
>
>

--047d7b162fd75923f504c2b979be--