Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of bchesneau@gmail.com
 designates 209.85.216.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAJNb-9rzcKaFjDjxNrzTLOP0KeZjXUBOUCia-a=wPPqN_QPK9A@mail.gmail.com>
References: 
 <CAN-3CB+HSn4RaokksY2tjVTKpS0Yp2nefhboD=01pV3pTme6Yg@mail.gmail.com>
	<1365184392016.73308dba@Nodemailer>
	<CAJNb-9rzcKaFjDjxNrzTLOP0KeZjXUBOUCia-a=wPPqN_QPK9A@mail.gmail.com>
Date: Fri, 5 Apr 2013 20:21:46 +0200
Message-ID: 
 <CAJNb-9oBn8=n30-Hjf6wuv+fCbHpCU-O5UVEYBkv2khwm9GinA@mail.gmail.com>
Subject: Re: git commit: Disable checking for string query_params values
From: Benoit Chesneau <bchesneau@gmail.com>
To: "dev@couchdb.apache.org" <dev@couchdb.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Thinking more about that issue, and I think that once the patch  for
the view changes will be integrated there is a need to accept any JSON
value there for the view params. Then maybe just removing the comments
since we won't have it anymore.

On Fri, Apr 5, 2013 at 8:12 PM, Benoit Chesneau <bchesneau@gmail.com> wrote=
:
> If the intention is to remove that filter, then why just comment it?
> Imo the patch should be reworked.
>
> Also not sure it should be re removed, the question is more why should
> we accept any JSON value there? What is the purpose? Shouldn't we on
> the contrary fix the replicator db to not accept that?
>
> This case looks similar to the possibility we add to pass any JSON
> values in roles. We decided in that case to forbid this usage if I
> remember well, didn't check in the commits. Isn't it  similar?
>
> I'm trying to understand the issue there. Also the discussion should
> probably happen on COUCHDB-1534 which is still open.
>
> - beno=EEt
>
> On Fri, Apr 5, 2013 at 7:53 PM, Noah Slater <apache@tumbolia.org> wrote:
>> Okay. Thanks!
>>
>> On Fri, Apr 5, 2013 at 6:01 PM, Jason Smith <jhs@iriscouch.com> wrote:
>>
>>> No and no.
>>> On Wed, Apr 3, 2013 at 12:24 AM, Noah Slater <nslater@apache.org> wrote=
:
>>>> Has it been backed out? (Should it be?)
>>>>
>>>>
>>>> On 25 March 2013 11:12, Jason Smith <jhs@iriscouch.com> wrote:
>>>>
>>>>> I checked, this commit is only in the COUCHDB-1534 branch in Git. It =
is not
>>>>> in any others (1.3.x, master).
>>>>>
>>>>>
>>>>> On Mon, Mar 25, 2013 at 11:09 AM, Jason Smith <jhs@iriscouch.com> wro=
te:
>>>>>
>>>>> > Oh wow, sorry, all, I missed this.
>>>>> >
>>>>> > The commit addresses COUCHDB-1534. However that issue is not yet cl=
osed
>>>>> > due to missing unit tests. And Paul wants to remove the function en=
tirely
>>>>> > (which is fine by me).
>>>>> >
>>>>> > The comment about iris-monitor was for me, when I diff our branch a=
gainst
>>>>> > ASF, I would recall the reason for the change. But it is spurious. =
I
>>>>> > believe I cherry-picked a commit and forgot about the comment.
>>>>> >
>>>>> >
>>>>> >
>>>>> > On Sat, Mar 23, 2013 at 8:02 PM, Noah Slater <nslater@apache.org> w=
rote:
>>>>> >
>>>>> >> Was this a mistaken commit? Was it resolved?
>>>>> >>
>>>>> >>
>>>>> >> On 10 October 2012 21:06, Jan Lehnardt <jan@apache.org> wrote:
>>>>> >>
>>>>> >> > Jason,
>>>>> >> >
>>>>> >> > did you mean to commit this to Apache?
>>>>> >> >
>>>>> >> > Cheers
>>>>> >> > Jan
>>>>> >> > --
>>>>> >> >
>>>>> >> >
>>>>> >> > On Sep 14, 2012, at 04:08 , jhs@apache.org wrote:
>>>>> >> >
>>>>> >> > > Updated Branches:
>>>>> >> > >  refs/heads/COUCHDB-1534 [created] 835b57b19
>>>>> >> > >
>>>>> >> > >
>>>>> >> > > Disable checking for string query_params values
>>>>> >> > >
>>>>> >> > >
>>>>> >> > > Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
>>>>> >> > > Commit:
>>>>> >> http://git-wip-us.apache.org/repos/asf/couchdb/commit/835b57b1
>>>>> >> > > Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/835b=
57b1
>>>>> >> > > Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/835b=
57b1
>>>>> >> > >
>>>>> >> > > Branch: refs/heads/COUCHDB-1534
>>>>> >> > > Commit: 835b57b196d423ae5132a559e727031521da8ce9
>>>>> >> > > Parents: 53490d9
>>>>> >> > > Author: Jason Smith (work) <jhs@iriscouch.com>
>>>>> >> > > Authored: Tue Sep 4 06:35:52 2012 +0000
>>>>> >> > > Committer: Jason Smith (air) <jhs@iriscouch.com>
>>>>> >> > > Committed: Fri Sep 14 09:02:04 2012 +0700
>>>>> >> > >
>>>>> >> > >
>>>>> ---------------------------------------------------------------------=
-
>>>>> >> > > src/couchdb/couch_httpd_replicator.erl |    6 ++++--
>>>>> >> > > 1 files changed, 4 insertions(+), 2 deletions(-)
>>>>> >> > >
>>>>> ---------------------------------------------------------------------=
-
>>>>> >> > >
>>>>> >> > >
>>>>> >> > >
>>>>> >> >
>>>>> >>
>>>>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/835b57b1/src/couc=
hdb/couch_httpd_replicator.erl
>>>>> >> > >
>>>>> ---------------------------------------------------------------------=
-
>>>>> >> > > diff --git a/src/couchdb/couch_httpd_replicator.erl
>>>>> >> > b/src/couchdb/couch_httpd_replicator.erl
>>>>> >> > > index fb1e350..47de476 100644
>>>>> >> > > --- a/src/couchdb/couch_httpd_replicator.erl
>>>>> >> > > +++ b/src/couchdb/couch_httpd_replicator.erl
>>>>> >> > > @@ -58,8 +58,10 @@ validate_rep_props([]) ->
>>>>> >> > > validate_rep_props([{<<"query_params">>, {Params}}|Rest]) ->
>>>>> >> > >     lists:foreach(fun
>>>>> >> > >         ({_,V}) when is_binary(V) -> ok;
>>>>> >> > > -        ({K,_}) -> throw({bad_request,
>>>>> >> > > -            <<K/binary," value must be a string.">>})
>>>>> >> > > +        % Disabled to support the iris-monitor replicator
>>>>> >> > > +        %({K,_}) -> throw({bad_request,
>>>>> >> > > +        %    <<K/binary," value must be a string.">>})
>>>>> >> > > +        ({K,_}) -> ok
>>>>> >> > >         end, Params),
>>>>> >> > >     validate_rep_props(Rest);
>>>>> >> > > validate_rep_props([_|Rest]) ->
>>>>> >> > >
>>>>> >> >
>>>>> >> >
>>>>> >>
>>>>> >>
>>>>> >> --
>>>>> >> NS
>>>>> >>
>>>>> >
>>>>> >
>>>>> >
>>>>> > --
>>>>> > Iris Couch
>>>>> >
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Iris Couch
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> NS
>>> --
>>> Iris Couch