Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BEFDD1E6 for ; Fri, 21 Dec 2012 23:40:31 +0000 (UTC) Received: (qmail 52877 invoked by uid 500); 21 Dec 2012 23:40:30 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 52838 invoked by uid 500); 21 Dec 2012 23:40:30 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 52816 invoked by uid 99); 21 Dec 2012 23:40:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2012 23:40:30 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [80.244.253.218] (HELO mail.traeumt.net) (80.244.253.218) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2012 23:40:22 +0000 Received: from [192.168.0.198] (91-64-59-226-dynip.superkabel.de [91.64.59.226]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.traeumt.net (Postfix) with ESMTPSA id 7DFA614370; Sat, 22 Dec 2012 00:34:55 +0100 (CET) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: [STATUS] CouchDB 1.3 release From: Jan Lehnardt In-Reply-To: Date: Sat, 22 Dec 2012 00:40:01 +0100 Cc: Noah Slater Content-Transfer-Encoding: quoted-printable Message-Id: <94722CF1-9CDF-4EDA-A4D5-981478BE576E@apache.org> References: <7F9E29D0-B617-44E3-8A67-3BC53DB4E2B0@apache.org> <071AA65F-4910-48F7-80BB-46D75333E086@apache.org> <6CCD9022-FD6F-4AB0-AFC4-2288DA4CE35C@apache.org> <0B823DF3-E7C6-47B7-929E-4A282F5D7402@apache.org> <56BA9212-37CF-41E5-88E3-C052AA87ACF7@apache.org> To: dev@couchdb.apache.org X-Mailer: Apple Mail (2.1499) X-Virus-Checked: Checked by ClamAV on apache.org On Dec 22, 2012, at 00:07 , Jan Lehnardt wrote: >=20 > On Dec 21, 2012, at 22:47 , Jan Lehnardt wrote: >=20 >> Good catch. >>=20 >> This seems to fix it: >>=20 >> diff --git a/Makefile.am b/Makefile.am >> index afeea73..22853fb 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -91,7 +91,7 @@ endif >> check-js: dev >> if TESTS >> if USE_CURL >> - $(top_builddir)/test/javascript/run >> + MAKE=3D$(MAKE) $(top_builddir)/test/javascript/run >> endif >> endif >>=20 >> diff --git a/test/javascript/run.tpl b/test/javascript/run.tpl >> index 267b6d0..a2d69fd 100644 >> --- a/test/javascript/run.tpl >> +++ b/test/javascript/run.tpl >> @@ -46,7 +46,7 @@ abort() { >>=20 >> # start CouchDB >> if [ -z $COUCHDB_NO_START ]; then >> - make dev >> + $MAKE dev >> trap 'abort' EXIT >> ./utils/run -b -r 1 -n \ >> -a $BUILD_DIR/etc/couchdb/default_dev.ini \ >>=20 >>=20 >> Shall I commit this to 1.3.x & master? >=20 > As a refinement, I=92d set $MAKE to 'make' if MAKE isn=92t set in the > environment, so ./test/javascript/run can be run standalone. >=20 > With this in place, `gmake distcheck` fails with >=20 > not ok 53 stats > Reason: We managed to force a all_dbs_active error. > Trace back (most recent call first): >=20 > 0:=20 > Error("We managed to force a all_dbs_active error.") > 46: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../test/jav= ascript/cli_runner.js > T(false,"We managed to force a all_dbs_active error.") > 100: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../share/ww= w/script/test/stats.js > () > 378: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../share/ww= w/script/couch_test_runner.js > run_on_modified_server([object Array],(function () {var pre_dbs =3D= getS > 118: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../share/ww= w/script/test/stats.js > () > 76: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../share/ww= w/script/test/stats.js > () > 53: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../test/jav= ascript/cli_runner.js > if (debug) {debugger;}(function () {var db =3D = newDb("test_suite_db");db > 72: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../test/jav= ascript/cli_runner.js > runAllTestsConsole() > 85: = /home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build/../test/jav= ascript/cli_runner.js >=20 >=20 > Kinda tired tonight, so probably not digging much deeper here. If = anyone has a clue, let us know! :) Yay: It fails in the CLI, but not from the browser. I don=92t quite see = how, but assume higher latency from the browser hits this. Also, this is = in VMware, so the disk is rather virtual. I tried injecting an = artificial delay in a few spots in stats.js, but could=92t see any = improvements. Paul, you refactored that test at some point in the past, maybe you have = an idea? Cheers Jan --=20 >=20 > Cheers > Jan > --=20 >=20 >=20 >=20 >>=20 >> Cheers >> Jan >> --=20 >>=20 >>=20 >>=20 >>=20 >>=20 >> On Dec 21, 2012, at 22:34 , Noah Slater wrote: >>=20 >>> We do some funky shit with 'SAFE_MAKE' as part of the docs changes, = but this should be portable. Judging by your paste, the problem is in = test/javascript/run, and sure enough, there are some raw make calls. = Looks like a longstanding issue. Are you able to experiment in this = file? It should be possible to pick up $MAKE. If not, 'export' it = manually from the calling Makefile.am. DM me if you need me to check = this thread again tonight or pop on to a laptop. >>>=20 >>> On Friday, 21 December 2012, Jan Lehnardt wrote: >>> Hi Noah, >>>=20 >>> On FreeBSD 9.0 `gmake distcheck`* fails with: >>>=20 >>> ... >>> ./test/javascript/run >>> make: don't know how to make w. Stop >>> gmake[1]: *** [check-js] Error 2 >>> gmake[1]: Leaving directory = `/usr/home/jan/src/couchdb/apache-couchdb-1.3.0a-4e1bf75-git/_build' >>> gmake: *** [distcheck] Error 1 >>>=20 >>> I can verify that manual execution of `gmake check` works just fine. = My guess would point at an invocation of make as `make` instead of = $(MAKE) somewhere in the distcheck bowels. A cursory look didn=92t = reveal anything obvious, so I hoped you can shed a light on this. >>>=20 >>> Thanks! >>> Jan >>> -- >>> * (FreeBSD users know to use `gmake` for `make`, as `make often = fails, including in our case) >>>=20 >>>=20 >>>=20 >>> On Dec 13, 2012, at 17:16 , Noah Slater wrote: >>>=20 >>>> Okay, thanks! >>>>=20 >>>>=20 >>>> On 13 December 2012 15:18, Benoit Chesneau = wrote: >>>>=20 >>>>> On Thu, Dec 13, 2012 at 3:52 PM, Noah Slater = wrote: >>>>>=20 >>>>>> How long do you want to digest the changes, Benoit? Can you be = specific? >>>>>>=20 >>>>>=20 >>>>> Like I said I was ;) Dave already answered to my question somehow. >>>>>=20 >>>>> - beno=EEt >>>>>=20 >>>>=20 >>>>=20 >>>>=20 >>>> -- >>>> NS >>>=20 >>>=20 >>>=20 >>> --=20 >>> NS >>=20 >=20