Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E3AACC6D for ; Thu, 17 May 2012 13:21:52 +0000 (UTC) Received: (qmail 26949 invoked by uid 500); 17 May 2012 13:21:52 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 26908 invoked by uid 500); 17 May 2012 13:21:51 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 26900 invoked by uid 99); 17 May 2012 13:21:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2012 13:21:51 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [80.244.253.218] (HELO mail.traeumt.net) (80.244.253.218) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2012 13:21:43 +0000 Received: from [172.20.10.2] (unknown [46.115.22.132]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mail.traeumt.net (Postfix) with ESMTPSA id 2E6951437A for ; Thu, 17 May 2012 15:23:08 +0200 (CEST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Apple Message framework v1257) Subject: Re: git commit: add Server-Sent Events protocol to db changes API. close #COUCHDB-986 From: Jan Lehnardt In-Reply-To: Date: Thu, 17 May 2012 15:21:19 +0200 Content-Transfer-Encoding: 7bit Message-Id: <4C4CCECF-1ADD-4813-B9BA-4D1404B1E993@apache.org> References: <20120516053615.720C7161E9@tyr.zones.apache.org> To: dev@couchdb.apache.org X-Mailer: Apple Mail (2.1257) X-Virus-Checked: Checked by ClamAV on apache.org On May 16, 2012, at 08:25 , Paul Davis wrote: >> It should be better on latest change witch take the undefined bit in >> consideration. CLI tests pass here. > > Good enough for me. with the if() around it, the test may pass on the CLI, but the particular EventSource test code is never run. Or are you confirming that the the test code actually runs on the CLI? Cheers Jan --