incubator-couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benoit Chesneau <bchesn...@gmail.com>
Subject Re: git commit: add Server-Sent Events protocol to db changes API. close #COUCHDB-986
Date Thu, 17 May 2012 13:55:23 GMT
On Thu, May 17, 2012 at 3:21 PM, Jan Lehnardt <jan@apache.org> wrote:
>
> On May 16, 2012, at 08:25 , Paul Davis wrote:
>
>>> It should be better on latest change witch take the undefined bit in
>>> consideration. CLI tests pass here.
>>
>> Good enough for me.
>
> with the if() around it, the test may pass on the CLI, but the particular
> EventSource test code is never run. Or are you confirming that the the
> test code actually runs on the CLI?
>
The code will never be abble to run on cli. Except if we emulate the
EventSource object. What we could do however is testing also the
return using an etap test.

- benoit

Mime
View raw message