Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Received-SPF: pass (google.com: domain of jhs@iriscouch.com designates
 10.52.26.8 as permitted sender) client-ip=10.52.26.8;
MIME-Version: 1.0
Sender: jhs@iriscouch.com
In-Reply-To: 
 <CAAL6JQj_WPXUP1ijG0TKYQu+odfYoX4ULcnG3ahs6_T2WBb-Lg@mail.gmail.com>
References: <20120229110959.0AE614CF87@tyr.zones.apache.org>
 <CAAL6JQj_WPXUP1ijG0TKYQu+odfYoX4ULcnG3ahs6_T2WBb-Lg@mail.gmail.com>
From: Jason Smith <jhs@apache.org>
Date: Thu, 1 Mar 2012 07:38:34 +0700
Message-ID: 
 <CAN-3CBK8n4CiH54WKq67WVd6bOJd39hxkwJ6Df6ypx4W6ry=iw@mail.gmail.com>
Subject: Re: [9/9] git commit: Testing requested_path for various combinations
 of rewrites and vhost
To: dev@couchdb.apache.org
Cc: Ryan Ramage <ryan@eckoit.com>
Content-Type: text/plain; charset=UTF-8

On Thu, Mar 1, 2012 at 3:17 AM, Randall Leeds <randall.leeds@gmail.com> wrote:
> I made a change to requested_path recently on master and 1.2 but
> didn't get much feedback about it.
> It seemed like it was obviously broken to me but maybe I misunderstood
> the intention.
> Is it working the way you expect?
>
> Relevant commit: 879a1bc19b145e126b9386aed2023f9cd1df8b31

The JIRA ticket indicates a bug when "hostname/path" was used as a
vhost. Ryan showed that the "/path" part is forgotten by the time
req.requested_path arrives in a _show function.

Jan said it's not a bug because paths in vhost keys are invalid. Or at
least, they *oughtn't* be valid. I thought the bug occurred even with
normal vhosts (no path) but several unit tests later, I realized that
is false. The only bug is when vhosts include a path component.

And so the *real* bug will probably be that CouchDB should reject non
well-formed vhost keys. The only remaining question is whether Ryan
used that feature because there was no possible alternative.