incubator-couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1355) split code & create couch_httpd application
Date Wed, 14 Dec 2011 03:08:32 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13169037#comment-13169037
] 

Paul Joseph Davis commented on COUCHDB-1355:
--------------------------------------------

Commencing brain dump review:

0001

  * src/Makefile.am indentation looks wrong for src/couch_httpd

  * include files is empty, but this might change in the next patch so just a note to self

  * We do a thing for couch.app.src in couchdb so we can set the module list automatically.
Should we duplicate that here?

  * couch_httpd.app is missing the module to start the app

0002

  * Yep, record moved. Looks good.

  * Whitespace only hunk at the bottom of 0002

0003

  * I'm not entirely certain about this patch. What's the circular dependency? If it's just
records in include files I don't think I'd bother making the split as it seems a bit awkward.
  
  * The couch_changes.app reminds me we should be listing dependencies better as we do this.
Not super urgent but a thing to think about.

This also brings up how we want to handle things like the httpd code for views. If anyone
has good ideas we should open a ticket and discuss a plan of some sort on how to handle this
going forward. I'm thinking specifically that the couch_httpd is separate from couch, but
couch_changes and couch_mrview have their httpd code in those apps.
                
> split code & create couch_httpd application
> -------------------------------------------
>
>                 Key: COUCHDB-1355
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1355
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core, HTTP Interface
>    Affects Versions: 1.3
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.3
>
>         Attachments: 0001-couch_httpd-application.patch, 0002-move-httpd-record-in-couch_httpd-include-couch_httpd.patch,
0003-create-couch_changes-application.-Fix-tests-and-allo.patch
>
>
> Couchdb is still to monolithic. This tcicket track changes to extract CouchDB HTTP API
as a full application.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message