Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Date: Mon, 8 Aug 2011 18:36:27 +0000 (UTC)
From: "Robert Newson (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: 
 <1397960204.17343.1312828587677.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1572705831.17052.1312823907349.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (COUCHDB-1242) Filtered replication silently
 converts all query parameters to strings
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/COUCHDB-1242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Newson updated COUCHDB-1242:
-----------------------------------

    Attachment: 0001-throw-400-bad_request-if-any-query_params-value-is-n.patch

Patch for 1.0.x

(should be similar for 1.1.x and completely wrong for trunk)

> Filtered replication silently converts all query parameters to strings
> ----------------------------------------------------------------------
>
>                 Key: COUCHDB-1242
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1242
>             Project: CouchDB
>          Issue Type: Bug
>    Affects Versions: 1.0.2, 1.1
>            Reporter: Robert Newson
>            Assignee: Robert Newson
>         Attachments: 0001-throw-400-bad_request-if-any-query_params-value-is-n.patch
>
>
> All filtered query params are silently converted to strings. this causes tests for if (req.query.foo) to evaluate to true even for {"query_params":{"foo":false}} because "false" is true.
> No clean solution exists to fix this as _changes has a GET entry point and request parameters are untyped.
> Suggested fix is to scan the query_params in handle_replicate_req and throw a 400 Bad Request if any value is not a JSON string.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira