Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of randall.leeds@gmail.com
 designates 209.85.210.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=Pcu/r+YdUxJK5i7rlL166JuGqzsybT7OxN+bHyYInliB2VR2pGtEs8wrKeS7R+Kmos
         KRvNn7ZBh9Jw+ovDcyIpfhkFN6ZUbSKoEgCwtMUm+TGG4GWDFZIsuYgH7N+5I9GG7wDB
         G4q7kW8ipzUBiAlAngd+UVt5ENh51wNgvm3IA=
MIME-Version: 1.0
Date: Tue, 8 Mar 2011 11:28:03 -0800
Message-ID: <AANLkTinuXhenkK7a73oYRGkSXqd0PERambq-Pw58pOpc@mail.gmail.com>
Subject: btree refactoring
From: Randall Leeds <randall.leeds@gmail.com>
To: dev@couchdb.apache.org
Content-Type: multipart/alternative; boundary=90e6ba6e8b106e0923049dfd9c7b

--90e6ba6e8b106e0923049dfd9c7b
Content-Type: text/plain; charset=UTF-8

When I start hacking on COUCHDB-1076 a couple nights ago I found that the
cleanest way I could see for allowing kp_nodes to be skipped during
traversal was for the fold function to couch_btree:foldl to be arity 4, with
kp_node | kv_node as the first argument.

Evaluating that function for every node (instead of just kv_nodes) lets us
return {skip, Acc} to skip whole subtrees.
Diving back into the couch_btree code to read over Damien's patch for
COUCHDB-1084, it hit me that ModifyFun could instead be a function that was
called for all the actions. We wouldn't need to return the query results
because this action function could send them back to the client as they're
found. Then we just keep the actions list as part of the accumulator and
query_modify collapses into a btree:foldl and we no longer need so many
similar-looking recursive functions. Off the cuff I envision modify_node
being exported and simplified to be non-recursive and query_modify being a
helper function to generate a fold function that uses modify_node (or
something like this).

Is this similar to anything you've done already, Paul? Would you all be
interested if I took a crack at doing this kind of refactor?

--90e6ba6e8b106e0923049dfd9c7b--