Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com
 designates 74.125.83.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :content-type:content-transfer-encoding;
        b=fGXoNih1iyexXyQQPOO2cTtnxcjMv2rQOMLKxDrf0uGbZdshuqX+sNWMiCCha3repf
         6jzGewnp8gZFE0253pA+ng06ahg4EZOQd/eqU3e3iaI7tw/PCrOabKLYEuuHTZTnaxZI
         hVCefLYQ7NwlreBUjM6PBiTM5cSW5l7hIBWLs=
MIME-Version: 1.0
In-Reply-To: <AANLkTinOjGJvw2_fxEgDqCD+2tV_KWEQPRJmCwVvq5TL@mail.gmail.com>
References: <20110202102644.2A3062388A3C@eris.apache.org>
 <AANLkTimS2gV9u0inj3JpGr0_bcgWHxj1hy1=T2wzQMz8@mail.gmail.com>
 <AANLkTinOjGJvw2_fxEgDqCD+2tV_KWEQPRJmCwVvq5TL@mail.gmail.com>
From: Paul Davis <paul.joseph.davis@gmail.com>
Date: Wed, 2 Feb 2011 14:37:15 -0500
Message-ID: <AANLkTi=VXY3jbhSbaTrVrLcH1pDNGckP7riPH1mzK66F@mail.gmail.com>
Subject: Re: svn commit: r1066404 -
 /couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

when is_list_of_lists?

On Wed, Feb 2, 2011 at 2:36 PM, Robert Newson <robert.newson@gmail.com> wro=
te:
> Ack, thanks. will fix (again)
>
> On Wed, Feb 2, 2011 at 7:17 PM, Filipe David Manana <fdmanana@apache.org>=
 wrote:
>> Robert,
>>
>>> - =A0 =A0 =A0 =A0[User | Pass] ->
>>> + =A0 =A0 =A0 =A0[User | Pass] when is_list(Pass) ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 {User, string:join(Pass, ":")};
>>> =A0 =A0 =A0 =A0 [User] ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 {User, ""};
>>
>> "Pass" will always be a list. The clause with a single element match
>> is the redundant one. Calling string:join(":") on an emply list/string
>> will return an empty list/string, so the [User] clause could go away.
>>
>> cheers
>>
>> On Wed, Feb 2, 2011 at 2:26 AM, =A0<rnewson@apache.org> wrote:
>>> Author: rnewson
>>> Date: Wed Feb =A02 10:26:43 2011
>>> New Revision: 1066404
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D1066404&view=3Drev
>>> Log:
>>> fix clause warning introduced with COUCHDB-969
>>>
>>> Modified:
>>> =A0 =A0couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
>>>
>>> Modified: couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
>>> URL: http://svn.apache.org/viewvc/couchdb/branches/1.1.x/src/couchdb/co=
uch_httpd_auth.erl?rev=3D1066404&r1=3D1066403&r2=3D1066404&view=3Ddiff
>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>> --- couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl (original)
>>> +++ couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl Wed Feb =A0=
2 10:26:43 2011
>>> @@ -53,7 +53,7 @@ basic_name_pw(Req) ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 nil;
>>> =A0 =A0 =A0 =A0 [User, Pass] ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 {User, Pass};
>>> - =A0 =A0 =A0 =A0[User | Pass] ->
>>> + =A0 =A0 =A0 =A0[User | Pass] when is_list(Pass) ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 {User, string:join(Pass, ":")};
>>> =A0 =A0 =A0 =A0 [User] ->
>>> =A0 =A0 =A0 =A0 =A0 =A0 {User, ""};
>>>
>>>
>>>
>>
>>
>>
>> --
>> Filipe David Manana,
>> fdmanana@gmail.com, fdmanana@apache.org
>>
>> "Reasonable men adapt themselves to the world.
>> =A0Unreasonable men adapt the world to themselves.
>> =A0That's why all progress depends on unreasonable men."
>>
>