Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Message-ID: <703444103.1249242794800.JavaMail.jira@brutus>
Date: Sun, 2 Aug 2009 12:53:14 -0700 (PDT)
From: "Jan Lehnardt (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Subject: [jira] Commented: (COUCHDB-288) couch_js.c:1217: error:
 'JSOPTION_NATIVE_BRANCH_CALLBACK' with spidermonkey tip
In-Reply-To: <1434196610.1236807530742.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738123#action_12738123 ] 

Jan Lehnardt commented on COUCHDB-288:
--------------------------------------

Thanks to Paul Davis, I could now apply the patch correctly. The issue seems to be that the #if JS_VERSION <= 170 doesn't get picked up correctly. When I comment out the if branch and only keep the else, the patch works. I see all tests passing but the show_documents one.

> couch_js.c:1217: error: 'JSOPTION_NATIVE_BRANCH_CALLBACK' with spidermonkey tip
> -------------------------------------------------------------------------------
>
>                 Key: COUCHDB-288
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-288
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Build System
>         Environment: linux-x86 latest erlang/otp spidermonkey from http://hg.mozilla.org/mozilla-central/
>            Reporter: Richard Brown
>            Priority: Blocker
>             Fix For: 0.10
>
>         Attachments: couchdb_spidermonkey_tip-1.diff
>
>
> libtool: link: ( cd ".libs" && rm -f "couch_erl_driver.la" && ln -s "../couch_erl_driver.la" "couch_erl_driver.la" )
> i686-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..   -D_XOPEN_SOURCE  -L/usr/local/lib -L/opt/local/lib -I/usr/lib/erlang/usr/include -I/usr/lib/erlang/usr/include -I/usr/local/lib/erlang/usr/include -I/opt/local/lib/erlang/usr/include -I/usr/include -I/usr/include/js -I/usr/include/mozjs -I/usr/local/include -I/opt/local/include -I/usr/local/include/js -I/opt/local/include/js -DXP_UNIX    -DMUDKIPZ -march=native -pipe -O2 -MT couchjs-couch_js.o -MD -MP -MF .deps/couchjs-couch_js.Tpo -c -o couchjs-couch_js.o `test -f 'couch_js.c' || echo './'`couch_js.c
> couch_js.c: In function 'main':
> couch_js.c:1217: error: 'JSOPTION_NATIVE_BRANCH_CALLBACK' undeclared (first use in this function)
> couch_js.c:1217: error: (Each undeclared identifier is reported only once
> couch_js.c:1217: error: for each function it appears in.)
> make[2]: Leaving directory `/var/tmp/paludis/build/dev-db-couchdb-scm/work/couchdb-scm/src/couchdb'
> make[2]: *** [couchjs-couch_js.o] Error 1
> make[1]: Leaving directory `/var/tmp/paludis/build/dev-db-couchdb-scm/work/couchdb-scm'
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
> Patching with 
> Index: src/couchdb/couch_js.c
> ===================================================================
> --- src/couchdb/couch_js.c	(revision 752552)
> +++ src/couchdb/couch_js.c	(working copy)
> @@ -1213,8 +1213,8 @@
>      if (!context)
>          return 1;
>      JS_SetErrorReporter(context, PrintError);
> -    JS_SetBranchCallback(context, BranchCallback);
> -    JS_ToggleOptions(context, JSOPTION_NATIVE_BRANCH_CALLBACK);
> +//    JS_SetBranchCallback(context, BranchCallback);
> +//    JS_ToggleOptions(context, JSOPTION_NATIVE_BRANCH_CALLBACK);
>      JS_ToggleOptions(context, JSOPTION_XML);
>  
>      global = JS_NewObject(context, NULL, NULL, NULL);
> compiles and "works" in so far as I can talk to futon
> I think it might me related to http://markmail.org/search/?q=JS_SetBranchCallback#query:JS_SetBranchCallback%20list%3Aorg.apache.couchdb.commits+page:1+mid:kgc3bx6rclmlpkvb+state:results

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.