Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 95035 invoked from network); 4 May 2009 22:09:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 4 May 2009 22:09:08 -0000 Received: (qmail 59227 invoked by uid 500); 4 May 2009 22:09:07 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 59165 invoked by uid 500); 4 May 2009 22:09:07 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 59155 invoked by uid 99); 4 May 2009 22:09:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 22:09:07 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jchris@gmail.com designates 74.125.46.31 as permitted sender) Received: from [74.125.46.31] (HELO yw-out-2324.google.com) (74.125.46.31) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2009 22:08:59 +0000 Received: by yw-out-2324.google.com with SMTP id 2so2154627ywt.5 for ; Mon, 04 May 2009 15:08:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=66dL1oD6BJj0CNE9BhoIfSOokrQ2sil/zk7t6rLn8/0=; b=sFBMC5E4fhts41CMO14p7Y0HlANKZsshMvMPYg2lTvO+PNYw8NuUMuunBALOkqWdBR RYNhU5U/GR+XB9z2SQ2Qe+ZfZbWr93SoY9ha8LF3YfeYl6I4W3Pv9aGcEj4YjXlTRlUq S/6p+1cIBFIQXtQ27cjdm76XRVHnXwA8PWnII= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:date:x-google-sender-auth:message-id:subject :from:to:content-type:content-transfer-encoding; b=tzxL5X1gH2EThs3d7r8t3G8i4RLXUxuMmaiqYp1J0OSuIbJmfmQCp30LTKPE82bX8/ sQCQJTlU0Ri7CHgQ7ZvzwK6pwnGuT8tqHCpfOV01TQo0mCTp+vyEpE/zetLOr5PRaMqu sEx0fSRMA97FmOWEh7OxuOBSKWJ7xm73q77jM= MIME-Version: 1.0 Sender: jchris@gmail.com Received: by 10.100.210.16 with SMTP id i16mr14216641ang.44.1241474918146; Mon, 04 May 2009 15:08:38 -0700 (PDT) Date: Mon, 4 May 2009 15:08:38 -0700 X-Google-Sender-Auth: 135f87758d4b501c Message-ID: Subject: reduce_limit error From: Chris Anderson To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Devs, I'm checking in a patch that should cut down on the number of mailing list questions asking why a particular reduce function is hella slow. Essentially the patch throws an error if the reduce function return value is not at least half the size of the values array that was passed in. (The check is skipped if the size is below a fixed amount, 200 bytes for now). I expect this heuristic will need fine tuning. Ideally we'd never raise the error on "good" reduces, and always raise it on "ill-conceived" ones. If you hit the error on a reduce that seems like it should be considered good, please ping the list so we have an opportunity to fine-tune. There is a config option: [query_server_config] reduce_limit = true changing this to false will revert to the old behavior. Ideally very few applications will require this config change, so if you find yourself changing this setting, it's a sign you should mail the list. -- Chris Anderson http://jchrisa.net http://couch.io