Mailing-List: contact couchdb-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: couchdb-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of adam.kocoloski@gmail.com
 designates 74.125.92.148 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:from:to:content-type:content-transfer-encoding
         :mime-version:subject:date:x-mailer;
        b=hWcyObCDdenGDpOW0zKrCkYGJfVOwNGgIZCcY27mSrr1hQ00uFRc/AjLNlFqmKCYwJ
         8Wh3OkT+M5GpDxn2Nh6FUZGvmSxymZpUFiCb3zXo3YkAVy5ot+Rui6xLYQQjo1UqvjFL
         YTJGyKMbtspieYQu5l+WT9aodJsXNcJ6pLB7g=
Message-Id: <0D2EE974-228C-4C7E-A4DC-61CF9D9C8A9F@gmail.com>
From: Adam Kocoloski <adam.kocoloski@gmail.com>
To: couchdb-dev@incubator.apache.org
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v926)
Subject: URL-decoding reverse proxy breaks remote replication
Date: Wed, 3 Sep 2008 14:38:08 -0400

Hi, I installed CouchDB behind nginx the other day and noticed that  
remote replication didn't work.  The problem seems to be that

a) CouchDB stores the replication history in a local doc with an ID  
formed from the URL-encoded paths to the source and target DBs,

b) nginx decodes all %2Fs in the URLs it processes, and

c) couch_httpd chokes on a GET request for the replication history doc  
using the decoded URL delivered by nginx.

My workaround was to encode "/" as "|" in the ID of the replication  
history document.  It seemed simpler than doing extra special-casing  
in couch_httpd to handle decoded "/" characters in replication docIDs,  
and I didn't see any way to turn off URL decoding in nginx.  Best,

Adam

--- a/trunk/src/couchdb/couch_rep.erl
+++ b/trunk/src/couchdb/couch_rep.erl
@@ -28,6 +28,9 @@ url_encode([H|T]) ->
          [H|url_encode(T)];
      H == $_; H == $.; H == $-; H == $: ->
          [H|url_encode(T)];
+    % nginx will decode the %2F which makes couch_httpd blow up
+    H == $/ ->
+        [$||url_encode(T)];
      true ->
          case lists:flatten(io_lib:format("~.16.0B", [H])) of
          [X, Y] ->