incubator-couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Anderson" <jch...@grabb.it>
Subject Re: [PATCH] Views: Multiple keys
Date Wed, 23 Jul 2008 16:56:30 GMT
On Wed, Jul 23, 2008 at 1:36 AM, Paul Bonser <misterpib@gmail.com> wrote:
> You use it by POSTing a JSON array of keys to a view url. Any passed-in values for start_key
and end_key are ignored.
>
> I haven't written any unittests for this yet, but I wanted to see what everyone else
thinks of this and ask if there's any obvious better way to accomplish the same goal.

Your patch looks good to me - haven't applied it yet but it seems
right. Seeing the unit tests would make it quite clear how to interact
with it. For instance, it may be that POSTing to the view url needs
more flexibility than just an array of keys. In that case, maybe
having the post body look like:

{"keys":["key1","key2","key3"]} rather than just ["key1","key2","key3"]

would be more flexible going forward.

Having some unit tests around the interaction with the MultiKeys and
Count, SkipCount, and StartDocId params would also be helpful I think.

Good work and thanks for the patch!

-- 
Chris Anderson
http://jchris.mfdz.com

Mime
View raw message