Mailing-List: contact connectors-commits-help@incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: connectors-dev@incubator.apache.org
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1157178 - in /incubator/lcf/trunk: CHANGES.txt
 framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java
Date: Fri, 12 Aug 2011 16:35:09 -0000
To: connectors-commits@incubator.apache.org
From: kwright@apache.org
Message-Id: <20110812163509.585312388897@eris.apache.org>

Author: kwright
Date: Fri Aug 12 16:35:08 2011
New Revision: 1157178

URL: http://svn.apache.org/viewvc?rev=1157178&view=rev
Log:
Fix for CONNECTORS-238.  The end notification is a nicety, so if it fails don't keep retrying (unless ServiceInterruption is thrown).

Modified:
    incubator/lcf/trunk/CHANGES.txt
    incubator/lcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java

Modified: incubator/lcf/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/incubator/lcf/trunk/CHANGES.txt?rev=1157178&r1=1157177&r2=1157178&view=diff
==============================================================================
--- incubator/lcf/trunk/CHANGES.txt (original)
+++ incubator/lcf/trunk/CHANGES.txt Fri Aug 12 16:35:08 2011
@@ -3,6 +3,10 @@ $Id$
 
 ======================= 0.3-dev =========================
 
+CONNECTORS-238: Hard errors from notification output connector method
+should be noted and then ignored.
+(Karl Wright)
+
 CONNECTORS-61: Make it easy (and document) how to integrate
 ManifoldCF into an application.
 (Karl Wright)

Modified: incubator/lcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java
URL: http://svn.apache.org/viewvc/incubator/lcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java?rev=1157178&r1=1157177&r2=1157178&view=diff
==============================================================================
--- incubator/lcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java (original)
+++ incubator/lcf/trunk/framework/pull-agent/src/main/java/org/apache/manifoldcf/crawler/system/JobNotificationThread.java Fri Aug 12 16:35:08 2011
@@ -113,7 +113,6 @@ public class JobNotificationThread exten
                     try
                     {
                       connector.noteJobComplete(activity);
-                      notifiedConnections.put(connections,connections);
                     }
                     catch (ServiceInterruption e)
                     {
@@ -130,8 +129,8 @@ public class JobNotificationThread exten
                         throw e;
                       // Nothing special; report the error and keep going.
                       Logging.threads.error(e.getMessage(),e);
-                      continue;
                     }
+                    notifiedConnections.put(connections,connections);
                   }
                   finally
                   {