incubator-composer-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r614271 - in /incubator/composer/trunk/composer-core/src: main/java/org/apache/composer/core/ main/java/org/apache/composer/core/injectors/ test/java/org/apache/composer/core/ test/java/org/apache/composer/core/defaults/ test/java/org/apach...
Date Tue, 22 Jan 2008 17:46:24 GMT
Author: mauro
Date: Tue Jan 22 09:46:08 2008
New Revision: 614271

URL: http://svn.apache.org/viewvc?rev=614271&view=rev
Log:
Removed PICO Jira issues references, replaced for non-obsolete one by relevant information
in code.

Modified:
    incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/DefaultContainer.java
    incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/injectors/AbstractInjector.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/DefaultContainerTestCase.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/CollectionComponentParameterTestCase.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/issues/Issue0280TestCase.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/ConstructorInjectorTestCase.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/SetterInjectorTestCase.java
    incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/tck/AbstractContainerTest.java

Modified: incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/DefaultContainer.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/DefaultContainer.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/DefaultContainer.java
(original)
+++ incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/DefaultContainer.java
Tue Jan 22 09:46:08 2008
@@ -285,7 +285,7 @@
 
     /** {@inheritDoc} **/
     private <T> ComponentAdapter<T> getComponentAdapter(final Class<T>
componentType, final NameBinding componentNameBinding, final Class<? extends Annotation>
binding) {
-        // See issue PICO-115
+        // Returns adapter by key if found
         ComponentAdapter<?> adapterByKey = getComponentAdapter(componentType);
         if (adapterByKey != null) {
             return typeComponentAdapter(adapterByKey);

Modified: incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/injectors/AbstractInjector.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/injectors/AbstractInjector.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/injectors/AbstractInjector.java
(original)
+++ incubator/composer/trunk/composer-core/src/main/java/org/apache/composer/core/injectors/AbstractInjector.java
Tue Jan 22 09:46:08 2008
@@ -160,7 +160,7 @@
     protected T caughtInstantiationException(final ComponentMonitor componentMonitor,
                                                 final Constructor<T> constructor,
                                                 final InstantiationException e, final Container
container) {
-        // can't get here because checkConcrete() will catch it earlier, but see PICO-191
+        // should not get here because checkConcrete() will catch it earlier
         componentMonitor.instantiationFailed(container, this, constructor, e);
         throw new CompositionException("Should never get here");
     }

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/DefaultContainerTestCase.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/DefaultContainerTestCase.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/DefaultContainerTestCase.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/DefaultContainerTestCase.java
Tue Jan 22 09:46:08 2008
@@ -126,10 +126,9 @@
 
 	/*
 	 * When container tries to resolve DecoratedTouchable it find as dependency
-	 * itself and SimpleTouchable. Problem is basically the same as above. Comooser
+	 * itself and SimpleTouchable. Problem is basically the same as above. Container
 	 * should not consider self as solution.
 	 * 
-	 * JS fixed it ( PICO-222 ) KP
 	 */
 	@Test public void testUnambiguouSelfDependency() {
 		MutableContainer container = createContainer(null);
@@ -570,8 +569,6 @@
 
 	}
 
-
-	// PICO-295 reported by Erik Putrycz
 	@Test public void testListComponentsInStart() {
 		DefaultContainer dpc = new DefaultContainer();
 		dpc.addComponent(SimpleTouchable.class);

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/CollectionComponentParameterTestCase.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/CollectionComponentParameterTestCase.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/CollectionComponentParameterTestCase.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/CollectionComponentParameterTestCase.java
Tue Jan 22 09:46:08 2008
@@ -370,8 +370,6 @@
 		parameterEmpty.verify(container, null, Cod[].class, null, false, null);
 	}
 
-	// PICO-243 : this test will fail if executed on jdk1.3 without
-	// commons-collections
 	@Test
 	public void testOrderOfElementsOfAnArrayDependencyIsPreserved() {
 		MutableContainer container = new DefaultContainer();

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/issues/Issue0280TestCase.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/issues/Issue0280TestCase.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/issues/Issue0280TestCase.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/defaults/issues/Issue0280TestCase.java
Tue Jan 22 09:46:08 2008
@@ -24,9 +24,6 @@
 import org.apache.composer.core.MutableContainer;
 import org.apache.composer.core.CompositionException;
 
-/**
- * Test case for issue PICO-280
- */
 public class Issue0280TestCase {
 
 	@Test

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/ConstructorInjectorTestCase.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/ConstructorInjectorTestCase.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/ConstructorInjectorTestCase.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/ConstructorInjectorTestCase.java
Tue Jan 22 09:46:08 2008
@@ -270,7 +270,6 @@
         }
     }
 
-    // PICO-201
     @Test public void testShouldNotConsiderNonPublicConstructors() {
         DefaultContainer container = new DefaultContainer();
         container.addComponent(Component201.class);

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/SetterInjectorTestCase.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/SetterInjectorTestCase.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/SetterInjectorTestCase.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/injectors/SetterInjectorTestCase.java
Tue Jan 22 09:46:08 2008
@@ -442,7 +442,7 @@
         }
     }
 
-    // TODO PICO-188
+    // TODO 
     public void FIXME_testShouldBeAbleToHandleMutualDependenciesWithSetterInjection() {
         MutableContainer container = new DefaultContainer(new Caching().wrap(new SetterInjection()));
 

Modified: incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/tck/AbstractContainerTest.java
URL: http://svn.apache.org/viewvc/incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/tck/AbstractContainerTest.java?rev=614271&r1=614270&r2=614271&view=diff
==============================================================================
--- incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/tck/AbstractContainerTest.java
(original)
+++ incubator/composer/trunk/composer-core/src/test/java/org/apache/composer/core/tck/AbstractContainerTest.java
Tue Jan 22 09:46:08 2008
@@ -398,8 +398,7 @@
         }
     }
 
-    // PICO-52
-    @Test public void testContainer52() {
+    @Test public void testContainerCanAddComponentWithConstantParameters() {
         MutableContainer container = createContainer(null);
 
         container.addComponent("foo", JMSService.class, new ConstantParameter("0"), new ConstantParameter("something"));



Mime
View raw message