Return-Path: X-Original-To: apmail-incubator-cloudstack-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2E5A6E2ED for ; Tue, 5 Mar 2013 18:38:15 +0000 (UTC) Received: (qmail 52589 invoked by uid 500); 5 Mar 2013 18:38:15 -0000 Delivered-To: apmail-incubator-cloudstack-issues-archive@incubator.apache.org Received: (qmail 52567 invoked by uid 500); 5 Mar 2013 18:38:15 -0000 Mailing-List: contact cloudstack-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-issues@incubator.apache.org Received: (qmail 52559 invoked by uid 99); 5 Mar 2013 18:38:14 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 18:38:14 +0000 Date: Tue, 5 Mar 2013 18:38:14 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-1190) Make APIChecker interface throw a single sensible exception MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CLOUDSTACK-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13593728#comment-13593728 ] ASF subversion and git services commented on CLOUDSTACK-1190: ------------------------------------------------------------- Commit 5750fd9631c8064df0f9bb95117aacf497e00c23 in branch refs/heads/ui-multiple-nics from [~minchen07] [ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=5750fd9 ] CLOUDSTACK-1190: make APIChecker throw one sensible exception. > Make APIChecker interface throw a single sensible exception > ----------------------------------------------------------- > > Key: CLOUDSTACK-1190 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1190 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Rohit Yadav > Assignee: Min Chen > Fix For: 4.1.0 > > > At present based on a plugin's requirements there are two exceptions that are said to be thrown by a plugin implementing the APIChecker interface. Make it throw only one standard exception, it can be a new exception as well. We should not allow every plugin to introduce their own exceptions; > public interface APIChecker extends Adapter { > ... > boolean checkAccess(User user, String apiCommandName) throws PermissionDeniedException, RequestLimitException; -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira