incubator-cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-1664) Action Events are not logged due to spring changes
Date Thu, 21 Mar 2013 00:53:15 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-1664?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chip Childers resolved CLOUDSTACK-1664.
---------------------------------------

    Resolution: Fixed

Applied to 4.1 now:

commit ebc10b6bf01ce4c0874ff59fd8731b75dc64304f
Author: Kelven Yang <kelven.yang@citrix.com>
Date:   Thu Mar 21 00:50:31 2013 +0000

    CLOUDSTACK-1568,CLOUDSTACK-1664: Fix ActionEvent interception and optimize @DB lookup
with caching
    
    Signed-off-by: Chip Childers <chip.childers@gmail.com>
                
> Action Events are not logged due to spring changes
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-1664
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1664
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.1.0
>         Environment: Build from 4.1
>            Reporter: Sangeetha Hariharan
>            Assignee: Kelven Yang
>            Priority: Critical
>             Fix For: 4.1.0
>
>
> ActionEvent annotations are in manager Impl. Spring proxies the interface and not the
implementing class. Since there are not annotations at the interface level, needToIntercept
method in ActionEventInterceptor always returns false.
> TransactionContextBuilder intercepts by getting the implementing class and going through
all the methods in it to match the method name. Going through all the methods every time may
not be efficient. There could be multiple methods with same name, so matching by method name
could be error prone aswell.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message