Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of animesh.chaturvedi@citrix.com
 designates 66.165.176.89 as permitted sender)
From: Animesh Chaturvedi <animesh.chaturvedi@citrix.com>
To: Nitin Mehta <Nitin.Mehta@citrix.com>,
	"cloudstack-dev@incubator.apache.org" <cloudstack-dev@incubator.apache.org>,
	Saksham Srivastava <saksham.srivastava@citrix.com>, Devdeep Singh
	<devdeep.singh@citrix.com>, Abhinandan Prateek
	<Abhinandan.Prateek@citrix.com>
Date: Tue, 5 Mar 2013 00:10:49 -0800
Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set to NULL
 when a template is created from a snapshot
Thread-Topic: Review Request: CLOUDSTACK-924: source_template_id set to NULL
 when a template is created from a snapshot
Thread-Index: Ac4Zd18/SPNWG6NJQvSOxev1CYcFMAAAYsUQ
Message-ID: 
 <7A92FF96DF135843B4B608FB576BFC3E012F751823D6@SJCPMAILBOX01.citrite.net>
References: 
 <7A92FF96DF135843B4B608FB576BFC3E012F74C418DA@SJCPMAILBOX01.citrite.net>
 <CD5BA385.124A2%nitin.mehta@citrix.com>
In-Reply-To: <CD5BA385.124A2%nitin.mehta@citrix.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Ok thanks for following up

Animesh

> -----Original Message-----
> From: Nitin Mehta
> Sent: Tuesday, March 05, 2013 12:00 AM
> To: Animesh Chaturvedi; cloudstack-dev@incubator.apache.org; Saksham
> Srivastava; Devdeep Singh; Abhinandan Prateek
> Subject: Re: Review Request: CLOUDSTACK-924: source_template_id set to
> NULL when a template is created from a snapshot
>=20
> Hi Animesh,
> Saksham is supposed to send a rebased request to me. Below is what he
> wrote to me.
>=20
>=20
>=20
> The code has changed a lot after the storage refactoring.
> I will submit a new patch after resolving the conflicts.
>=20
> Saksham
>=20
>=20
> On Thursday 28 February 2013 12:03 PM, Nitin Mehta wrote:
> >Nitins-MacBook-Air:incubator-cloudstack nitinmehta$ git apply
> >--whitespace=3Dfix ../pppp.patch
> >error: patch failed:
> >server/src/com/cloud/storage/StorageManagerImpl.java:477
> >error: server/src/com/cloud/storage/StorageManagerImpl.java: patch does
> >not apply Nitins-MacBook-Air:incubator-cloudstack nitinmehta$
> >
>=20
>=20
>=20
> On 01/03/13 3:57 AM, "Animesh Chaturvedi"
> <animesh.chaturvedi@citrix.com>
> wrote:
>=20
> >Nitin
> >
> >This has been pending your review since couple of days. Please attend
> >to this review and close it
> >
> >Animesh
> >
> >> -----Original Message-----
> >> From: Animesh Chaturvedi [mailto:animesh.chaturvedi@citrix.com]
> >> Sent: Wednesday, February 13, 2013 7:34 PM
> >> To: Saksham Srivastava; Nitin Mehta; Devdeep Singh
> >> Cc: cloudstack
> >> Subject: RE: Review Request: CLOUDSTACK-924: source_template_id set
> >> to NULL when a template is created from a snapshot
> >>
> >> Nitin
> >>
> >> Please review the updates patch and commit if satisfied
> >>
> >> > -----Original Message-----
> >> > From: Saksham Srivastava [mailto:noreply@reviews.apache.org] On
> >> > Behalf Of Saksham Srivastava
> >> > Sent: Monday, February 11, 2013 3:38 AM
> >> > To: Nitin Mehta; Devdeep Singh
> >> > Cc: Saksham Srivastava; cloudstack
> >> > Subject: Re: Review Request: CLOUDSTACK-924: source_template_id
> set
> >> > to NULL when a template is created from a snapshot
> >> >
> >> >
> >> > -----------------------------------------------------------
> >> > This is an automatically generated e-mail. To reply, visit:
> >> > https://reviews.apache.org/r/8900/
> >> > -----------------------------------------------------------
> >> >
> >> > (Updated Feb. 11, 2013, 11:37 a.m.)
> >> >
> >> >
> >> > Review request for cloudstack, Devdeep Singh and Nitin Mehta.
> >> >
> >> >
> >> > Description
> >> > -------
> >> >
> >> > Volumes created from snapshots misses the source template
> >> > information.Fixed the issue with volumes now getting the template id=
.
> >> >
> >> >
> >> > This addresses bug CLOUDSTACK-924.
> >> >
> >> >
> >> > Diffs
> >> > -----
> >> >
> >> >   server/src/com/cloud/storage/StorageManagerImpl.java 05e0cfe
> >> >
> >> > Diff: https://reviews.apache.org/r/8900/diff/
> >> >
> >> >
> >> > Testing
> >> > -------
> >> >
> >> > Verified on local setup. from
> >> > template1->instance->snapshot1->volume1-
> >> > >snapshot2->template2
> >> > template2 now has source template id.
> >> >
> >> >
> >> > Thanks,
> >> >
> >> > Saksham Srivastava
> >