Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============4865324098684102325=="
MIME-Version: 1.0
Subject: Review Request: MidoNet Networking Plugin [2/2]
From: "Dave Cahill" <dcahill@midokura.com>
To: "Chiradeep Vittal" <chiradeepv@gmail.com>,
 "Hugo Trippaers" <htrippaers@schubergphilis.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Dave Cahill" <dcahill@midokura.com>
Date: Wed, 13 Mar 2013 09:32:25 -0000
Message-ID: <20130313093225.1181.76964@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Dave Cahill" <noreply@reviews.apache.org>
Reply-To: "Dave Cahill" <dcahill@midokura.com>

--===============4865324098684102325==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9898/
-----------------------------------------------------------

Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.


Description
-------

Feature spec:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Midokura+Networking+=
Plugin

Jira ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-996

Notes:

* Moved plugin to nonoss since the MidoNet client jar is not publicly avail=
able

* Documentation will follow as a separate commit

* One main difference from existing networking plugins is the lack of a Res=
ource class; we didn't feel it was necessary in this case. As mentioned in =
Extending CloudStack Networking [1]:
"Just like managers, resources are not strictly necessary. In theory a Netw=
ork Element could implement a client for the API of the new controller and =
therefore be completely self-contained."

* We allow overriding Public traffic via the MidoNetPublicNetworkGuru. We c=
hecked this approach with the list [2] and received no comments, so we're g=
oing with it for now.

[1] https://cwiki.apache.org/CLOUDSTACK/extending-cloudstack-networking.html
[2] http://markmail.org/message/k5qse63eyylszm3i


This addresses bug CLOUDSTACK-996.


Diffs
-----

  api/src/com/cloud/network/Network.java efed5cd =

  api/src/com/cloud/network/Networks.java e3d2158 =

  api/src/com/cloud/network/PhysicalNetwork.java 343a2b1 =

  api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java b=
c22804 =

  client/pom.xml cda6ab8 =

  client/tomcatconf/nonossComponentContext.xml.in 20e0c32 =

  deps/install-non-oss.sh 74575a8 =

  plugins/hypervisors/kvm/pom.xml 013a58d =

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDoma=
inXMLParser.java b622b6d =

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDe=
f.java c93aeeb =

  plugins/network-elements/midokura-midonet/pom.xml 7f2e2d3 =

  plugins/network-elements/midonet/pom.xml PRE-CREATION =

  plugins/network-elements/midonet/src/com/cloud/network/element/MidoNetEle=
ment.java 48833b3 =

  plugins/network-elements/midonet/src/com/cloud/network/element/SimpleFire=
wallRule.java PRE-CREATION =

  plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetGuestN=
etworkGuru.java ed0eb3c =

  plugins/network-elements/midonet/src/com/cloud/network/guru/MidoNetPublic=
NetworkGuru.java PRE-CREATION =

  plugins/network-elements/midonet/src/com/cloud/network/resource/MidoNetVi=
fDriver.java PRE-CREATION =

  plugins/network-elements/midonet/test/com/cloud/network/element/MidoNetEl=
ementTest.java PRE-CREATION =

  plugins/pom.xml 88f617b =

  server/src/com/cloud/configuration/Config.java 64465a2 =

  server/src/com/cloud/network/NetworkManagerImpl.java 3220c91 =

  ui/scripts/system.js 4d529ae =


Diff: https://reviews.apache.org/r/9898/diff/


Testing
-------

Built and deployed, spun up Advanced Isolated network with two VMs, verifie=
d internal and external connectivity via MidoNet.


Thanks,

Dave Cahill


--===============4865324098684102325==--