Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D607BDF78 for ; Tue, 12 Mar 2013 19:33:30 +0000 (UTC) Received: (qmail 91158 invoked by uid 500); 12 Mar 2013 19:33:30 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 91012 invoked by uid 500); 12 Mar 2013 19:33:30 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 91002 invoked by uid 99); 12 Mar 2013 19:33:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Mar 2013 19:33:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0B9291C018A; Tue, 12 Mar 2013 19:33:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3705363509593639941==" MIME-Version: 1.0 Subject: Re: Review Request: fix /etc/hosts error in virtual router From: "Wei Zhou" To: "Chip Childers" , "cloudstack" , "Wei Zhou" Date: Tue, 12 Mar 2013 19:33:30 -0000 Message-ID: <20130312193330.1180.31778@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Wei Zhou" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9882/ X-Sender: "Wei Zhou" References: <20130312192710.1181.56482@reviews.apache.org> In-Reply-To: <20130312192710.1181.56482@reviews.apache.org> Reply-To: "Wei Zhou" --===============3705363509593639941== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9882/ ----------------------------------------------------------- (Updated March 12, 2013, 7:33 p.m.) Review request for cloudstack. Changes ------- add JIRA ticket (CLOUDSTACK-1652). Description ------- When create the instance with the name same to previous instances, the /etc= /hosts in virtual router has an error. = For example: 192.168.0.1 r-148-VM 192.168.0.1 r-148-VM 192.168.0.99 test-w006-001 192.168.0.138 test-w006-002 192.168.0.37 test-w006-003 192.168.0.33 test-w006-004 192.168.0.1 r-148-VM 192.168.0.235 test-w006-001 192.168.0.17 test-w006-002 It should be: 192.168.0.37 test-w006-003 = 192.168.0.33 test-w006-004 = 192.168.0.1 r-148-VM = 192.168.0.235 test-w006-001 = 192.168.0.17 test-w006-002 = This addresses bug CLOUDSTACK-1652. Diffs ----- patches/systemvm/debian/config/root/edithosts.sh 3c6102d = Diff: https://reviews.apache.org/r/9882/diff/ Testing ------- Testing manually ok. Thanks, Wei Zhou --===============3705363509593639941==--