Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 99004E3B1 for ; Fri, 8 Mar 2013 09:05:25 +0000 (UTC) Received: (qmail 18860 invoked by uid 500); 8 Mar 2013 09:05:25 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 18617 invoked by uid 500); 8 Mar 2013 09:05:24 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 18585 invoked by uid 99); 8 Mar 2013 09:05:23 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Mar 2013 09:05:23 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B8F951C70A5; Fri, 8 Mar 2013 09:05:14 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3900184166368621918==" MIME-Version: 1.0 Subject: Review Request: CLOUDSTACK-1509. During CreateVLANIPRange while trying to assign Public IPs to a new network if the network offering is persistent we get an NPE. From: "Likitha Shetty" To: "Chip Childers" Cc: "cloudstack" , "Likitha Shetty" Date: Fri, 08 Mar 2013 09:05:14 -0000 Message-ID: <20130308090514.27129.7977@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Likitha Shetty" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9817/ X-Sender: "Likitha Shetty" Reply-To: "Likitha Shetty" --===============3900184166368621918== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9817/ ----------------------------------------------------------- Review request for cloudstack and Chip Childers. Description ------- On master - ee9f97f92ef7d395f6a15f92225c9964e86a15e8 Applies cleanly on 4.1. Unit Tested. This addresses bug CLOUDSTACK-1509. Diffs ----- server/src/com/cloud/configuration/ConfigurationManagerImpl.java 62f4fd5 = Diff: https://reviews.apache.org/r/9817/diff/ Testing ------- Thanks, Likitha Shetty --===============3900184166368621918==--