Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 15DCB9E6B for ; Wed, 6 Mar 2013 23:28:49 +0000 (UTC) Received: (qmail 85490 invoked by uid 500); 6 Mar 2013 23:28:48 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 85451 invoked by uid 500); 6 Mar 2013 23:28:48 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 85432 invoked by uid 99); 6 Mar 2013 23:28:47 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Mar 2013 23:28:47 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 94AFD1C7E83; Wed, 6 Mar 2013 23:28:39 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1722386701720091334==" MIME-Version: 1.0 Subject: Re: Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong From: "Hiroaki Kawai" To: "Min Chen" Cc: "cloudstack" , "Hiroaki Kawai" Date: Wed, 06 Mar 2013 23:28:39 -0000 Message-ID: <20130306232839.27098.68063@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Hiroaki Kawai" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9786/ X-Sender: "Hiroaki Kawai" References: <20130306232831.27129.28687@reviews.apache.org> In-Reply-To: <20130306232831.27129.28687@reviews.apache.org> Reply-To: "Hiroaki Kawai" --===============1722386701720091334== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9786/ ----------------------------------------------------------- (Updated March 6, 2013, 11:28 p.m.) Review request for cloudstack and Min Chen. Description ------- I'm sorry this is a bug I put before in the patch of CLOUDSTACK-1529 ( http= s://reviews.apache.org/r/9768/ ) . The bug is that cookie header value assi= gned was a single value from cookie key value pair. Correct value is a seri= alized format of key value pairs which can be get by CookieSpec#formatCooki= es. This addresses bug CLOUDSTACK-1558. Diffs ----- vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a= 9 = Diff: https://reviews.apache.org/r/9786/diff/ Testing ------- Thanks, Hiroaki Kawai --===============1722386701720091334==--