Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Date: Wed, 6 Mar 2013 10:50:44 -0500
From: Chip Childers <chip.childers@sungard.com>
To: Wido den Hollander <wido@widodh.nl>
Cc: cloudstack-dev@incubator.apache.org, Noa Resare <noa@resare.com>
Subject: Re: Review Request: 4.1 deb packaging tomcat fixes
Message-ID: <20130306155044.GM88519@USLT-205755.sungardas.corp>
References: <20130302233403.17326.41450@reviews.apache.org>
 <20130302233414.17326.41697@reviews.apache.org>
 <20130306154631.GL88519@USLT-205755.sungardas.corp>
 <51376567.5050806@widodh.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51376567.5050806@widodh.nl>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Mar 06, 2013 at 04:48:55PM +0100, Wido den Hollander wrote:
> 
> On 03/06/2013 04:46 PM, Chip Childers wrote:
> >Wido / Noa:
> >
> >Is this ready to pull into 4.1?
> >
> 
> I've been debugging the agent and common package the last couple of days.
> 
> The packages themself seem to work, but it's all the small tweaks
> which take time.
> 
> The agent package should be pretty stable now. It is spread out over
> multiple commits though, so they have to be cherry-picked.

OK - so ideally it would be a clean patch.  But if you get things to a
point where you want them moved to 4.1, and need it to be a set of
cherry-picks, please just provide the (ordered) list of commit-sh
values.

> 
> Wido
> 
> >
> >On Sat, Mar 02, 2013 at 11:34:14PM +0000, Noa Resare wrote:
> >>
> >>-----------------------------------------------------------
> >>This is an automatically generated e-mail. To reply, visit:
> >>https://reviews.apache.org/r/9714/
> >>-----------------------------------------------------------
> >>
> >>(Updated March 2, 2013, 11:34 p.m.)
> >>
> >>
> >>Review request for cloudstack and Wido den Hollander.
> >>
> >>
> >>Description
> >>-------
> >>
> >>Changes isolated to the deb package build files, to fix
> >>failure to start management server from deb built packages
> >>
> >>* Adds the tomcat6 bootstrap jar to outer classpath
> >>* Removes install of cloud-server-4.1.0-SNAPSHOT.jar
> >>   in /usr/share/cloudstack-management/lib. This causes
> >>   /usr/share/cloudstack-management structure to be in the
> >>   way tomcat expects it to
> >>* Update paths to logfiles, which restores log4j functionality
> >>
> >>CLOUDSTACK-1490: 4.1 deb management fails to start
> >>
> >>
> >>This addresses bug CLOUDSTACK-1490.
> >>
> >>
> >>Diffs
> >>-----
> >>
> >>   debian/rules ba9056e
> >>   packaging/debian/replace.properties fee1def
> >>
> >>Diff: https://reviews.apache.org/r/9714/diff/
> >>
> >>
> >>Testing
> >>-------
> >>
> >>
> >>Thanks,
> >>
> >>Noa Resare
> >>
> 
>