Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37ACBDFEE for ; Tue, 5 Mar 2013 17:59:42 +0000 (UTC) Received: (qmail 78447 invoked by uid 500); 5 Mar 2013 17:59:41 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 78401 invoked by uid 500); 5 Mar 2013 17:59:41 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 78391 invoked by uid 99); 5 Mar 2013 17:59:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Mar 2013 17:59:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8B9C91C7D90; Tue, 5 Mar 2013 17:59:33 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3977623597834897157==" MIME-Version: 1.0 Subject: Re: Review Request: Fix for CLOUDSTACK-1473: deleteDomain is failing with NPE From: "Chip Childers" To: "Chip Childers" Cc: "cloudstack" , "Kishan Kavala" Date: Tue, 05 Mar 2013 17:59:33 -0000 Message-ID: <20130305175933.27098.951@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chip Childers" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/9749/ X-Sender: "Chip Childers" References: <20130305115504.27129.95992@reviews.apache.org> In-Reply-To: <20130305115504.27129.95992@reviews.apache.org> Reply-To: "Chip Childers" --===============3977623597834897157== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9749/#review17409 ----------------------------------------------------------- Ship it! Applied to 4.1 branch: commit bf40ab48f2af9368b391995ffde2f9e0a3877b48 Author: Kishan Kavala Date: Tue Mar 5 17:19:03 2013 +0530 CLOUDSTACK-1473: cleanp flag is optional param for deleteDomain API. Ch= eck for null before converting it to string - Chip Childers On March 5, 2013, 11:55 a.m., Kishan Kavala wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9749/ > ----------------------------------------------------------- > = > (Updated March 5, 2013, 11:55 a.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > cleanp flag is optional param for deleteDomain API. = > Check for null before converting it to string to avoid NPE. > = > = > This addresses bug CLOUDSTACK-1473. > = > = > Diffs > ----- > = > server/src/org/apache/cloudstack/region/RegionManagerImpl.java b4b55fd = > = > Diff: https://reviews.apache.org/r/9749/diff/ > = > = > Testing > ------- > = > Tested domain deletion with and without cleanup flag. > = > = > Thanks, > = > Kishan Kavala > = > --===============3977623597834897157==--