incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nitin Mehta <Nitin.Me...@citrix.com>
Subject Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
Date Mon, 11 Mar 2013 04:27:49 GMT
Roxanne - Thanks very much for working on this.
My take on the fix was to remove the entry for secondary storage from host
table as we do not create an agent for it. We should rather have another
table for secondary storage and related info.

On 11/03/13 7:59 AM, "roxanne chang" <roxanne_chang@trend.com.tw> wrote:

>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/9818/
>-----------------------------------------------------------
>
>(Updated March 11, 2013, 2:29 a.m.)
>
>
>Review request for cloudstack.
>
>
>Description
>-------
>
>Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status
>[https://issues.apache.org/jira/browse/CLOUDSTACK-1594]
>
>In file SecondarySotrageManagerImpl.java, function generateSetupCommand,
>if the host type is Secondary storage VM, the logic is to set
>secondarystorage host, at this time, secondarystorage host stauts should
>become Up.
>
>The secondary storage host always remains Alert status, because before
>the secondary storage vm is deployed, the secondary storage host is
>created. The tricky way (in the end of file AgentManagerImpl.java,
>function NotifiMonitorsOfConnection) will try to disconnect secondary
>storage, therefore the secondary storage host becomes Alert status. The
>code should take SSVM into consider, not only Answer reponse.
>
>File ResourceManagerImpl.java, function discoverHostsFull, in the end
>will call discoverer.postDiscovery, in file
>SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is
>not needed since its use to make secondary storage host wait for SSVM
>already done in SecondarySotrageManagerImpl. This makes why secondary
>storage host always remains Alert status.
>
>
>This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1594.
>
>
>Diffs
>-----
>
>  server/src/com/cloud/agent/manager/AgentManagerImpl.java c1bbb58
>  server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java
>3ca74a3 
>  server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java
>46ac7af 
>
>Diff: https://reviews.apache.org/r/9818/diff/
>
>
>Testing
>-------
>
>Test 4.0.0, 4.2.0 in basic mode, works well.
>
>
>Thanks,
>
>roxanne chang
>


Mime
View raw message