incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <min.c...@citrix.com>
Subject Re: copying scripts in client/pom.xml
Date Fri, 08 Mar 2013 00:21:30 GMT
Hugo, did you already fix this issue? With today's master, I can see that
the permission is right for injectkeys.sh, and I don't need to manually
tweak anymore in running Vmware test. Thanks.

-min

On 3/6/13 12:09 AM, "Hugo Trippaers" <HTrippaers@schubergphilis.com> wrote:

>Hey Frank,
>
>How about we tackle this in another way by explicitly calling '/bin/bash
><script>' instead of depending on the os to detect it's a shell script
>with an execute flag? More portable solution that does not  depend on
>permissions being kept between builds and deployments?
>
>Hugo
>
>> -----Original Message-----
>> From: Frank Zhang [mailto:Frank.Zhang@citrix.com]
>> Sent: Wednesday, March 06, 2013 12:29 AM
>> To: cloudstack-dev@incubator.apache.org
>> Cc: Hugo Trippaers (trippie@gmail.com)
>> Subject: RE: copying scripts in client/pom.xml
>> 
>> Hmm, it doesn't work as Min stated
>> 
>> The final script path is
>>client/target/cloud-client-ui-4.1.0-SNAPSHOT/WEB-
>> INF/classes/scripts which I think is generated from jetty plugin.
>> Maven as java problem seems to have the same problem with copying. We
>> have to check if jetty has a way to chmod
>> 
>> > -----Original Message-----
>> > From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>> > Sent: Tuesday, March 05, 2013 12:11 AM
>> > To: cloudstack-dev@incubator.apache.org
>> > Cc: Hugo Trippaers (trippie@gmail.com)
>> > Subject: RE: copying scripts in client/pom.xml
>> >
>> > Hey Frank,
>> >
>> > I think I found the same thing, please check this commit
>> > https://git-wip-
>> > us.apache.org/repos/asf?p=incubator-
>> > cloudstack.git;a=commit;h=d922f6fd4b41d939ee00c55638d8c5e8b56c8b77
>> >
>> > Does that work for you?
>> >
>> > Cheers,
>> >
>> > Hugo
>> >
>> > > -----Original Message-----
>> > > From: Frank Zhang [mailto:Frank.Zhang@citrix.com]
>> > > Sent: Tuesday, March 05, 2013 2:33 AM
>> > > To: cloudstack-dev@incubator.apache.org
>> > > Cc: Hugo Trippaers (trippie@gmail.com)
>> > > Subject: RE: copying scripts in client/pom.xml
>> > >
>> > > No worry.
>> > > I found a solution that explicitly call 'chmod' task of ant to add
>>executed
>> bits.
>> > > I will fix it tomorrow
>> > >
>> > > > -----Original Message-----
>> > > > From: Hugo Trippaers [mailto:HTrippaers@schubergphilis.com]
>> > > > Sent: Saturday, March 02, 2013 11:35 AM
>> > > > To: cloudstack-dev@incubator.apache.org
>> > > > Cc: Hugo Trippaers (trippie@gmail.com)
>> > > > Subject: RE: copying scripts in client/pom.xml
>> > > >
>> > > > Hey Frank,
>> > > >
>> > > > I reopened the ticket with the following comment:
>> > > >
>> > > > I reverted this commit because it breaks the system for developers
>> > > > who use an operating system that has no cp or mkdir command (the
>> > > > mkdir was later added by Rohit)
>> > > >
>> > > > I did not notice the original issue because the executable bit is
>> > > > not an issue on windows systems. We should find an alternative way
>> > > > to do this to solve this problem in a way that works on all
>> > > > operating systems. It's mainly a developer problem as the
>> > > > permissions are set using the packaging scripts for deployments.
>> > > >
>> > > > A check if mkdir and cp exists before doing the copy should work i
>> > > > think, but maybe there is an ant task that will take care of the
>> > > > permissions on unix based systems. Or maybe explicitly call bash
>> > > > instead of depending to the os to execute the script. I don't have
>> > > > much time this weekend, but I'm willing to see if I can find a
>> > > > solution next
>> > > week.
>> > > >
>> > > >
>> > > > Cheers,
>> > > >
>> > > > Hugo
>> > > >
>> > > > > -----Original Message-----
>> > > > > From: Chip Childers [mailto:chip.childers@sungard.com]
>> > > > > Sent: zaterdag 2 maart 2013 20:01
>> > > > > To: cloudstack-dev@incubator.apache.org
>> > > > > Cc: Hugo Trippaers (trippie@gmail.com)
>> > > > > Subject: Re: copying scripts in client/pom.xml
>> > > > >
>> > > > > On Fri, Mar 01, 2013 at 03:20:38PM -0800, Frank Zhang wrote:
>> > > > > > Hi Hugo:
>> > > > > > 	I noticed your recent change as below. It will cause bug
>> > > > > > https://issues.apache.org/jira/browse/CLOUDSTACK-1304 that
I
>> > > > > > have fixed some days ago
>> > > > > >
>> > > > > >
>> > > > > > be141f6e (Hugo Trippaers     2013-03-01 08:22:40 +0100 271)
>> > > <copy
>> > > > > todir="${basedir}/target/generated-webapp/WEB-
>> INF/classes/scripts"
>> > > > > >
>> > > > > > be141f6e (Hugo Trippaers     2013-03-01 08:22:40 +0100 272)
>> > > > > <fileset dir="${basedir}/../scripts" />
>> > > > > > be141f6e (Hugo Trippaers     2013-03-01 08:22:40 +0100 273)
>> > > > > </copy>
>> > > > > >
>> > > > > >
>> > > > > > 	my fixes basically does:
>> > > > > >
>> > > > > >                 <exec executable="cp">
>> > > > > >                     <arg value="-r" />
>> > > > > >                     <arg value="${basedir}/../scripts"
/>
>> > > > > >                     <arg
>> > > > > > value="${basedir}/target/generated-webapp/WEB-
>> > > > > INF/classes/scripts" />
>> > > > > >                 </exec>
>> > > > > >
>> > > > > >                 Is there any special reason you changed
it
>>back?
>> > > > > > Thank you
>> > > > > >
>> > > > >
>> > > > > Frank / Hugo - Should we reopen CLOUDSTACK-1304?
>> > > > >
>> > > > > I'd also suggest that the description of the bug makes it a bit
>> > > > > higher than the Major designation (i.e.: we should fix it in
>>4.1).


Mime
View raw message