incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus Sorensen <shadow...@gmail.com>
Subject Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup
Date Sat, 02 Mar 2013 19:39:06 GMT
I went back and looked at the wiki, and I think I misunderstood one of
the sections. It shows examples of things to put into the commit,
Reviewed-by:,Signed-off-by:,Reported-by:, and then below that,
CLOUDSTACK-bug-id:, Maven:, Doc:, etc.  It says the latter group
should be prefixes, which I apparently thought meant "begin your lines
with these". Most people seem to be using those as the beginning of
the actual commit message, so I'll conform to that.

On Sat, Mar 2, 2013 at 12:34 PM, Chip Childers
<chip.childers@sungard.com> wrote:
> On Sat, Mar 02, 2013 at 12:28:55PM -0700, Marcus Sorensen wrote:
>> The bug was created a few hours before the commit. I didn't even know
>> I'd end up fixing it. I thought we had standardized on a BUG-ID:
>> header in commits, way back in October or so when Rohit was asking for
>> better commit messages. We even created a pre-commit hook people could
>> use to prepopulate their commits with common fields.
>
> You're totally right!
>
> For some reason, I didn't see the bug ID.  Blind to the exact info I was
> looking for I guess!

Mime
View raw message