incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marcus Sorensen <shadow...@gmail.com>
Subject Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup
Date Sat, 02 Mar 2013 19:28:55 GMT
The bug was created a few hours before the commit. I didn't even know
I'd end up fixing it. I thought we had standardized on a BUG-ID:
header in commits, way back in October or so when Rohit was asking for
better commit messages. We even created a pre-commit hook people could
use to prepopulate their commits with common fields.

On Sat, Mar 2, 2013 at 12:25 PM, Chip Childers
<chip.childers@sungard.com> wrote:
> On Fri, Mar 01, 2013 at 07:37:24PM -0700, Marcus Sorensen wrote:
>> Please cherry pick to 4.1, it allows agent setup to complete properly
>> when host is added. This might actually have something to do with all
>> of the 'no private.network.device in agent.properties' issues popping
>> up from the testers.
>
> Applied and pushed!
>
> Can you do us a favor, and open bugs before committing for issues like
> this?  Especially if it's actually as bad as described.
>
> Then, you can add the CLOUDSTACK-XXXX number as the start of the commit
> message.
>
> Obviously, all you did was add a newline...  but it's helpful to be able
> to track things like above.
>
>>
>>
>> commit e08281838a428a26f1993519de96fc45a26c0920
>> Author: Marcus Sorensen <marcus@betterservers.com>
>> Date:   Fri Mar 1 19:26:38 2013 -0700
>>
>>     Summary: Add EOF to agent.properties for proper parsing
>>
>>     Detail: lack of newline at end of file was keeping
>> cloudstack-setup-agent from
>>     properly editing/creating new config.
>>
>>     BUG-ID: CLOUDSTACK-1487
>>     Signed-off-by: Marcus Sorensen <marcus@betterservers.com> 1362191198 -0700
>>

Mime
View raw message